Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile #16

Merged
merged 7 commits into from
Feb 23, 2024
Merged

Makefile #16

merged 7 commits into from
Feb 23, 2024

Conversation

garlic0x1
Copy link
Contributor

  1. Fix typo in usage output.
  2. Add Makefile for easy building from source.
  3. Use https URL for submodules, git URL denies permission.
  4. Add instructions to Readme for building from source.

The Makefile using the updated submodule URL should help installation process for this guy #11

Copy link
Owner

@cxxxr cxxxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to the project, I think it's great.
I think it's generally good, so I'll merge it and correct the areas you commented on on our side, so please let me know if there are any problems.

Comment on lines +16 to +20
install:
cp $(PROGNAME) $(INSTALLDIR)/$(PROGNAME)

uninstall:
rm $(INSTALLDIR)/$(PROGNAME)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two may not be my favorite.
The user may have to decide where to install them. (e.g. $HOME/.local/bin, $HOME/bin)

@cxxxr cxxxr merged commit 1a640ac into cxxxr:master Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants