First idea and step for refactoring for php 8.1+ #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 5, 2024 10:52
This patch set is too huge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
I would like to help step by step to make the Jsonmapper with types and future-proof.
In the first step, I added RectorPHP, PHPStan and ECS as dependencies to focus on type safety. All resulting bugs and problems have been fixed so that all current Unittest and PHPCS are green again.
In the next step, I would like to see the structure behind the facade refreshed to make it easier to make changes later, if that's okay with you. On the outside, little or nothing else should change from the library.
I really like this library and would like to help make it fit for the future.
Best Regards Wundii
P.S. this version would be something for 5.0-dev