Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #7

Merged
merged 18 commits into from
Jul 19, 2024
Merged

Dev #7

merged 18 commits into from
Jul 19, 2024

Conversation

AramisDuf
Copy link
Collaborator

Separated solver choice and problem formulation. Updated example notebooks. Updated tests.

@bmeyers
Copy link
Member

bmeyers commented May 15, 2024

@pluflou Could you please take a look at our failing conda build?

@pluflou
Copy link
Collaborator

pluflou commented May 15, 2024

@phschiele I see you worked on the recent 1.5 release of CVXPY. Our build is failing when it was previously fine with 1.4.3. Previously we had issues with pybind11 and I had manually added it as a dependency but it doesn't seem to be the issue now (I tried removing it) and there is no error reported during the install. Do you know what could be the issue?

@phschiele
Copy link

@pluflou Can you pin CVXPY version 1.4.3 to make sure that's actually what's causing the failure? It is not obvious to me from looking at the logs.

@pluflou
Copy link
Collaborator

pluflou commented May 16, 2024

@phschiele see runs #14 and #15. If I pin to 1.4.3 and add pybind11 as a runtime dependency it's successful. With 1.5 it fails either way without any install error messages other than "cvxpy is not installed" at test import.

@pluflou
Copy link
Collaborator

pluflou commented May 16, 2024

@phschiele @bmeyers @Thistleman I also see this in solar-data-tools when I reran a previously passing conda build that was installing 1.4.3, now fails with 1.5.1 with the same error
image.
Not sure if it's our build process or something with cvxpy, still looking into it. If anyone has any clue what could be the issue, please let me know!

@bmeyers
Copy link
Member

bmeyers commented May 16, 2024

It looks to me like run #15 was successful with cvxpy 1.5.1 installed.

Screenshot 2024-05-16 at 2 05 02 PM

Right?

@pluflou
Copy link
Collaborator

pluflou commented May 16, 2024

@bmeyers no that's installing 1.4.3 in the build step (from the conda recipe). I think this is an issue with my understanding of what conda is doing in those different steps and what happens during the build.

@bmeyers
Copy link
Member

bmeyers commented May 16, 2024

Ah yes, I see the distinction now, thank you.

@pluflou
Copy link
Collaborator

pluflou commented May 21, 2024

I adjusted the conda recipe with a pin on cvxpy, and added sig-decomp and its dependencies. @AramisDuf some tests are still failing. Let me know when you're ready for a merge.

@bmeyers bmeyers merged commit 772fe93 into main Jul 19, 2024
3 checks passed
@bmeyers bmeyers deleted the dev branch July 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants