-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #7
Conversation
@pluflou Could you please take a look at our failing conda build? |
@phschiele I see you worked on the recent 1.5 release of CVXPY. Our build is failing when it was previously fine with 1.4.3. Previously we had issues with pybind11 and I had manually added it as a dependency but it doesn't seem to be the issue now (I tried removing it) and there is no error reported during the install. Do you know what could be the issue? |
@pluflou Can you pin CVXPY version 1.4.3 to make sure that's actually what's causing the failure? It is not obvious to me from looking at the logs. |
@phschiele see runs #14 and #15. If I pin to 1.4.3 and add pybind11 as a runtime dependency it's successful. With 1.5 it fails either way without any install error messages other than "cvxpy is not installed" at test import. |
@phschiele @bmeyers @Thistleman I also see this in solar-data-tools when I reran a previously passing conda build that was installing 1.4.3, now fails with 1.5.1 with the same error |
It looks to me like run #15 was successful with cvxpy Right? |
@bmeyers no that's installing 1.4.3 in the build step (from the conda recipe). I think this is an issue with my understanding of what conda is doing in those different steps and what happens during the build. |
Ah yes, I see the distinction now, thank you. |
I adjusted the conda recipe with a pin on cvxpy, and added sig-decomp and its dependencies. @AramisDuf some tests are still failing. Let me know when you're ready for a merge. |
Separated solver choice and problem formulation. Updated example notebooks. Updated tests.