Faraday 0.9 compatibility (vcr source from master) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I think this is the best solution; for development purpose you Bundler anyway. However, vcr should be present only in the I think the CIs are failing due to a secured access tokens (they're not available for PR builds). Could you please verify that tests pass with new VCR? |
|
After changes:
Some of them fails before my changes beeing applied:
Also in #10 I've fixed all of them. |
added 3 commits
April 11, 2015 22:19
…is/kosapi_client.rb into feature/faraday-0.9-compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
separate branch for this issue.
IMHO the fault is on vcr's side. The fix was merged to master in October 2014, but no tagged version was released since September 2014.
I've found a workaround in moving the vcr from kosapi_client.gemspec to Gemfile and use master branch (maybe lock commit sha) as
gem 'vcr', github: 'vcr/vcr', branch: 'master'. It's not a nice one, but once again isn't vcr just a development (testing) dependency?#8 (comment)