welldone-software#11 return the same instance in makeArray when the…

… argument is an array
cvetanov · Feb 12, 2018 · 363edbd · 363edbd
1 parent c1819bd
commit 363edbd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/redux-toolbelt-immutable-helpers/src/makeArray.js b/packages/redux-toolbelt-immutable-helpers/src/makeArray.js
@@ -1,6 +1,6 @@
 import concat from 'lodash.concat'
+import isArray from 'lodash.isarray'
 
 export default function makeArray(arrayOrObject) {
-  // Converts the object into array (if it's not an array already)
-  return concat(arrayOrObject)
+  return isArray(arrayOrObject) ? arrayOrObject : concat(arrayOrObject)
 }
diff --git a/packages/redux-toolbelt-immutable-helpers/test/makeArray.js b/packages/redux-toolbelt-immutable-helpers/test/makeArray.js
@@ -10,12 +10,12 @@ test('makeArray creates array from object', () => {
   expect(result).toEqual([obj])
 })
 
-test('makeArray copies the provided array to a new one', () => {
+test('makeArray returns the same array when provided an array', () => {
   const arr = Object.freeze(
     [{id: 1, val: 5}, {id: 2, val: 6}]
   )
 
   const result = makeArray(arr)
 
-  expect(result).toEqual(arr)
+  expect(result).toBe(arr)
 })