Introduce cron jobs to clean up the export cache (data/cache/export/) and temporary files/directories (data/tmp/)

changelog.d/20241224_150942_maria_clear_cache_cron_job.md

@@ -0,0 +1,12 @@
+### Added
+
+- Setting `TMP_FILE_OR_DIR_RETENTION_DAYS`, which defines maximum retention period
+  of a file or dir in temporary directory
+  (<https://github.com/cvat-ai/cvat/pull/8804>)
+- Cron job to remove outdated files and directories from CVAT tmp directory
+  (<https://github.com/cvat-ai/cvat/pull/8804>)
+
+### Changed
+
+- Export cache cleaning moved to a separate cron job
+  (<https://github.com/cvat-ai/cvat/pull/8804>)

cvat/apps/dataset_manager/cron.py

@@ -0,0 +1,143 @@
+# Copyright (C) 2025 CVAT.ai Corporation
+#
+# SPDX-License-Identifier: MIT
+
+from __future__ import annotations
+
+import os
+import shutil
+from abc import ABCMeta, abstractmethod
+from datetime import timedelta
+from pathlib import Path
+from typing import ClassVar, Type
+
+from django.conf import settings
+from django.utils import timezone
+
+from cvat.apps.dataset_manager.util import (
+    CacheFileOrDirPathParseError,
+    ExportCacheManager,
+    TmpDirManager,
+    get_export_cache_lock,
+)
+from cvat.apps.dataset_manager.views import (
+    EXPORT_CACHE_LOCK_ACQUISITION_TIMEOUT,
+    EXPORT_CACHE_LOCK_TTL,
+    get_export_cache_ttl,
+    log_exception,
+)
+from cvat.apps.engine.log import ServerLogManager
+
+logger = ServerLogManager(__name__).glob
+
+
+def clear_export_cache(file_path: Path) -> bool:
+    with get_export_cache_lock(
+        file_path,
+        block=True,
+        acquire_timeout=EXPORT_CACHE_LOCK_ACQUISITION_TIMEOUT,
+        ttl=EXPORT_CACHE_LOCK_TTL,
+    ):
+        parsed_filename = ExportCacheManager.parse_filename(file_path.name)
+        cache_ttl = get_export_cache_ttl(parsed_filename.instance_type)
+
+        if timezone.now().timestamp() <= file_path.stat().st_mtime + cache_ttl.total_seconds():
+            logger.debug(f"Export cache file {file_path.name!r} was recently accessed")
+            return False
+
+        os.remove(file_path)
+        logger.debug(f"Export cache file {file_path.name!r} was successfully removed")
+        return True
+
+
+class BaseCleaner(metaclass=ABCMeta):
+    task_description: ClassVar[str]
+
+    def __init__(self) -> None:
+        self._number_of_removed_objects = 0
+
+    @property
+    def number_of_removed_objects(self) -> int:
+        return self._number_of_removed_objects
+
+    @abstractmethod
+    def do_cleanup(self):
+        pass
+
+
+class TmpDirectoryCleaner(BaseCleaner):
+    task_description: ClassVar[str] = "common temporary directory cleanup"
+
+    def do_cleanup(self) -> None:
+        # we do not use locks here when handling objects from tmp directory
+        # because undesired race conditions are not possible here:
+        # 1. A temporary file/directory can be removed while checking access time.
+        #    In that case an exception is expected and is handled by the cron process.
+        # 2. A temporary file/directory can be removed by the cron job only when it is outdated.
+        # 3. Each temporary file/directory has a unique name, so the race condition when one process is creating an object
+        #    and another is removing it - impossible.
+        for child in os.scandir(TmpDirManager.TMP_ROOT):
+            try:
+                if (
+                    child.stat().st_atime
+                    + timedelta(days=TmpDirManager.TMP_FILE_OR_DIR_RETENTION_DAYS).total_seconds()
+                    < timezone.now().timestamp()
+                ):
+                    if child.is_dir():
+                        shutil.rmtree(child.path)
+                    else:
+                        os.remove(child.path)
+                    logger.debug(f"The {child.name} was successfully removed")
+                    self._number_of_removed_objects += 1
+            except FileNotFoundError:
+                # file or directory has been removed by another process
+                continue
+            except Exception:
+                log_exception(logger)
+
+
+class ExportCacheDirectoryCleaner(BaseCleaner):
+    task_description: ClassVar[str] = "export cache directory cleanup"
+
+    def do_cleanup(self) -> None:
+        export_cache_dir_path = settings.EXPORT_CACHE_ROOT
+        assert os.path.exists(export_cache_dir_path)
+
+        for child in os.scandir(export_cache_dir_path):
+            # export cache directory is expected to contain only files
+            if not child.is_file():
+                logger.warning(f"The {child.name} is not a file, skipping...")
+                continue
+
+            try:
+                if clear_export_cache(child):
+                    self._number_of_removed_objects += 1
+            except CacheFileOrDirPathParseError:
+                logger.warning(f"Cannot parse {child.name}, skipping...")
+                continue
+
+            except Exception:
+                log_exception(logger)
+
+
+def cleanup(CleanerClass: Type[ExportCacheDirectoryCleaner | TmpDirectoryCleaner]) -> None:
+    assert issubclass(CleanerClass, BaseCleaner)
+    started_at = timezone.now()
+
+    cleaner = CleanerClass()
+    cleaner.do_cleanup()
+
+    finished_at = timezone.now()
+    logger.info(
+        f"The {cleaner.task_description!r} process has been successfully "
+        f"completed after {int((finished_at - started_at).total_seconds())} seconds. "
+        f"{cleaner.number_of_removed_objects} elements have been removed"
+    )
+
+
+def cleanup_export_cache_directory() -> None:
+    cleanup(ExportCacheDirectoryCleaner)
+
+
+def cleanup_tmp_directory() -> None:
+    cleanup(TmpDirectoryCleaner)

cvat/apps/dataset_manager/management/__init__.py

@@ -0,0 +1,4 @@
+# Copyright (C) 2025 CVAT.ai Corporation
+#
+# SPDX-License-Identifier: MIT
+

cvat/apps/dataset_manager/management/commands/__init__.py

@@ -0,0 +1,4 @@
+# Copyright (C) 2025 CVAT.ai Corporation
+#
+# SPDX-License-Identifier: MIT
+

cvat/apps/dataset_manager/management/commands/cleanuplegacyexportcache.py

@@ -0,0 +1,46 @@
+# Copyright (C) 2025 CVAT.ai Corporation
+#
+# SPDX-License-Identifier: MIT
+
+import shutil
+from contextlib import suppress
+from pathlib import Path
+
+from django.core.management.base import BaseCommand
+from django.utils import timezone
+
+from cvat.apps.engine.models import Job, Project, Task
+
+
+class Command(BaseCommand):
+    help = "Cleanup outdated export cache"
+
+    def handle(self, *args, **options):
+        def update_progress():
+            progress = (i + 1) / objects_count
+            done = int(progress_bar_len * progress)
+            progress_bar = "#" * done + "-" * (progress_bar_len - done)
+            self.stdout.write(f"\rProgress: |{progress_bar}| {progress:.0%}", ending="")
+
+        now = timezone.now()
+        progress_bar_len = shutil.get_terminal_size().columns // 2
+
+        for Model in (Project, Task, Job):
+            self.stdout.write(f"\nDeleting the export cache for {Model.__name__.lower()}s...")
+            queryset = Model.objects.filter(created_date__lt=now)
+            objects_count = queryset.count()
+            if objects_count < 1:
+                continue
+
+            msg = (
+                f"{objects_count} folders are going to be checked"
+                if objects_count > 1
+                else "1 folder is going to be checked"
+            )
+            self.stdout.write(msg)
+
+            for i, obj in enumerate(queryset.iterator()):
+                update_progress()
+                export_cache_dir = Path(obj.get_dirname()) / "export_cache"
+                with suppress(FileNotFoundError):
+                    shutil.rmtree(export_cache_dir)

cvat/apps/dataset_manager/project.py

@@ -3,9 +3,9 @@
 #
 # SPDX-License-Identifier: MIT
 
-import os
+import io
 from collections.abc import Mapping
-from tempfile import TemporaryDirectory
+from contextlib import nullcontext
 from typing import Any, Callable
 
 import rq
@@ -14,6 +14,7 @@
 from django.db import transaction
 
 from cvat.apps.dataset_manager.task import TaskAnnotation
+from cvat.apps.dataset_manager.util import TmpDirManager
 from cvat.apps.engine import models
 from cvat.apps.engine.log import DatasetLogManager
 from cvat.apps.engine.rq_job_handler import RQJobMetaField
@@ -26,8 +27,15 @@
 
 dlogger = DatasetLogManager()
 
-def export_project(project_id, dst_file, format_name,
-        server_url=None, save_images=False):
+def export_project(
+    project_id: int,
+    dst_file: str,
+    *,
+    format_name: str,
+    server_url: str | None = None,
+    save_images: bool = False,
+    temp_dir: str | None = None,
+):
     # For big tasks dump function may run for a long time and
     # we dont need to acquire lock after the task has been initialized from DB.
     # But there is the bug with corrupted dump file in case 2 or
@@ -39,7 +47,7 @@ def export_project(project_id, dst_file, format_name,
 
     exporter = make_exporter(format_name)
     with open(dst_file, 'wb') as f:
-        project.export(f, exporter, host=server_url, save_images=save_images)
+        project.export(f, exporter, host=server_url, save_images=save_images, temp_dir=temp_dir)
 
 class ProjectAnnotationAndData:
     def __init__(self, pk: int):
@@ -131,16 +139,26 @@ def init_from_db(self):
             self.task_annotations[task.id] = annotation
             self.annotation_irs[task.id] = annotation.ir_data
 
-    def export(self, dst_file: str, exporter: Callable, host: str='', **options):
+    def export(
+        self,
+        dst_file: io.BufferedWriter,
+        exporter: Callable[..., None],
+        *,
+        host: str = '',
+        temp_dir: str | None = None,
+        **options
+    ):
         project_data = ProjectData(
             annotation_irs=self.annotation_irs,
             db_project=self.db_project,
             host=host
         )
 
-        temp_dir_base = self.db_project.get_tmp_dirname()
-        os.makedirs(temp_dir_base, exist_ok=True)
-        with TemporaryDirectory(dir=temp_dir_base) as temp_dir:
+        with (
+            TmpDirManager.get_tmp_directory_for_export(
+                instance_type=self.db_project.__class__.__name__,
+            ) if not temp_dir else nullcontext(temp_dir)
+        ) as temp_dir:
             exporter(dst_file, temp_dir, project_data, **options)
 
     def load_dataset_data(self, *args, **kwargs):
@@ -155,9 +173,7 @@ def import_dataset(self, dataset_file, importer, **options):
         )
         project_data.soft_attribute_import = True
 
-        temp_dir_base = self.db_project.get_tmp_dirname()
-        os.makedirs(temp_dir_base, exist_ok=True)
-        with TemporaryDirectory(dir=temp_dir_base) as temp_dir:
+        with TmpDirManager.get_tmp_directory() as temp_dir:
             try:
                 importer(dataset_file, temp_dir, project_data, load_data_callback=self.load_dataset_data, **options)
             except (DatasetNotFoundError, CvatDatasetNotFoundError) as not_found: