Skip to content

Commit

Permalink
Fixed: Extra shortcuts enabled from brush tools on views where not ne…
Browse files Browse the repository at this point in the history
…cessary (#8971)
  • Loading branch information
bsekachev authored Jan 21, 2025
1 parent 5a99e73 commit 1140a92
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
4 changes: 4 additions & 0 deletions changelog.d/20250121_135206_sekachev.bs_fixed_rendering.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Fixed

- Extra shortcuts enabled from brush tools on views where not necessary
(<https://github.com/cvat-ai/cvat/pull/8971>)
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ import { ShortcutScope } from 'utils/enums';
import { registerComponentShortcuts } from 'actions/shortcuts-actions';
import { subKeyMap } from 'utils/component-subkeymap';
import ImageSetupsContent from './image-setups-content';
import BrushTools from './brush-tools';
import CanvasTipsComponent from './canvas-hints';

const cvat = getCore();
Expand Down Expand Up @@ -1144,8 +1143,6 @@ class CanvasWrapperComponent extends React.PureComponent<Props> {
}}
/>

<BrushTools />

<Popover
destroyTooltipOnHide
trigger='click'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ import React from 'react';
import Layout from 'antd/lib/layout';

import CanvasLayout from 'components/annotation-page/canvas/grid-layout/canvas-layout';
import BrushTools from 'components/annotation-page/canvas/views/canvas2d/brush-tools';
import SingleShapeSidebar from './single-shape-sidebar/single-shape-sidebar';

export default function SingleShapeWorkspace(): JSX.Element {
return (
<Layout hasSider className='cvat-single-shape-workspace'>
<CanvasLayout />
<BrushTools />
<SingleShapeSidebar />
</Layout>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ import CanvasPointContextMenuComponent from 'components/annotation-page/canvas/v
import IssueAggregatorComponent from 'components/annotation-page/review/issues-aggregator';
import RemoveConfirmComponent from 'components/annotation-page/standard-workspace/remove-confirm';
import PropagateConfirmComponent from 'components/annotation-page/standard-workspace/propagate-confirm';
import BrushTools from 'components/annotation-page/canvas/views/canvas2d/brush-tools';

export default function StandardWorkspaceComponent(): JSX.Element {
return (
<Layout hasSider className='cvat-standard-workspace'>
<ControlsSideBarContainer />
<CanvasLayout />
<BrushTools />
<ObjectSideBarComponent objectsList={<ObjectsListContainer />} />
<PropagateConfirmComponent />
<CanvasContextMenuContainer />
Expand Down

0 comments on commit 1140a92

Please sign in to comment.