-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports getting multiple snippet variants from community #2804
Open
AndreasArvidsson
wants to merge
23
commits into
main
Choose a base branch
from
snippetVariants
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/cursorless-engine/src/actions/GenerateSnippet/GenerateSnippet.ts
Dismissed
Show dismissed
Hide dismissed
AndreasArvidsson
commented
Feb 1, 2025
@@ -1,35 +1,48 @@ | |||
languageId: typescript | |||
command: | |||
version: 6 | |||
spokenForm: snippet if | |||
version: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new file that just happens to have the same name as a removed file
AndreasArvidsson
commented
Feb 1, 2025
@@ -1,28 +1,34 @@ | |||
languageId: plaintext | |||
command: | |||
version: 6 | |||
spokenForm: snippet spaghetti | |||
version: 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new test with a different file name. Just git being stupid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cursorless side of talonhub/community#1718
Will allow Cursorless to fetch multiple snippets from community and decide which one to use.
Release notes
Cursorless can now get multiple snippets from community. One for each language. Cursorless can then pick the correct snippet for the document language regardless of which document is focused at the moment.