Ep/h2c #17
Open
Ep/h2c #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlcritic --verbose 6 h2c gives the following result: Variable declared in conditional statement at line 400, near 'my $lib="--libcurl - -x localhost:0 " if($uselibcurl);'. (Severity: 5) Fix it.
perlcritic --verbose 6 h2c gives the following result: Bareword file handle opened at line 406, near 'open(C, "$curlcmd 2>/dev/null|");'. (Severity: 5) Fix it.
perlcritic --verbose 6 h2c gives the following result: Two-argument "open" used at line 405, near 'open(C, "$curlcmd 2>/dev/null|");'. (Severity: 5) Fix it.
perlcritic --verbose 6 h2c gives the following result:
Code before strictures are enabled at line 5, near 'sub usage {'. (Severity: 5)
For fix it:
- Add "use strict; use warnings"
- Add where necessary the "my" keyword to the lexically scoped variables.
- Fix also some uninitialized variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the perlcritic warnings. To do this I also introduced "use strict; use warnings" and therefore I had to introduce the necessary changes described in the commits