Fix build #174
Merged
Fix build #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build out of the box, but the default build still has the warning: "⚠ Warning: Using npm rather than upstream version of Emglken"
I'm not sure how I'm "supposed" to make that warning go away, but I deleted
node_modules/emglkenand replaced it with a symlink to../src/upstream/emglken. I then manually did a build insrc/upstream/emglkenwithbuild.sh.That symlink trickery made the warning go away, and the build still worked, so I think this PR should be safe to merge in both cases.