Fixing UpdateH5 logic in Sdk.targets #85
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not running the compilation server.
|
@theolivenbaum any thoughts on this change? I'm open to suggestions. I've tested this out and it works great for us. We would love to see this merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to set UpdateH5 to false to disable the update of the global h5 compiler when not using the compilation server.
This change updates the checks to make this possible.
Summary of the updated behavior:
If using the global compiler and it is not installed, UpdateH5 gets set to true so that it gets installed. (Now this simply calls h5 instead of h5 check-if-online which would return non-zero if the server was not running even though h5 was installed.)
If using the global compiler and it is installed, then do whatever is indicated by UpdateH5.
If using the local compiler always set UpdateH5 to false - never update or install.