Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulling colors into variables #148

Merged
merged 1 commit into from
Jun 17, 2015
Merged

pulling colors into variables #148

merged 1 commit into from
Jun 17, 2015

Conversation

mapsam
Copy link
Member

@mapsam mapsam commented Jun 17, 2015

This PR adds a thematic color scheme to dropchop (not definite, but was good to work with) and pulls a lot of our shared variables into the _variables.scss file so we can update styles easily without having to skim through a ton of .scss files.

screen shot 2015-06-17 at 12 07 14 am

alukach added a commit that referenced this pull request Jun 17, 2015
pulling colors into variables
@alukach alukach merged commit 51eb127 into master Jun 17, 2015
@alukach
Copy link
Member

alukach commented Jun 17, 2015

Looks good to me!

@mapsam mapsam deleted the style-updates branch June 17, 2015 15:44
@mapsam
Copy link
Member Author

mapsam commented Jun 17, 2015

Woop! I also added a couple more fonts, a monospace and a new sans-serif (Roboto). Mostly, I was getting sick of staring at what we had 😉

@alukach
Copy link
Member

alukach commented Jun 17, 2015

I do like the aesthetics of this, but one concern that I have with this particular color palette is that it may possibly clash-with/influence the visual styling of data that a user may want to add (assuming #126 and #130 get employed). I think the data and base-layer itself should be the primary focus from a user's perspective (which is something that a really neutral palette supports well).

ie. If I'm processing and styling data that I intend to put on a red-toned site, these colors could make it more difficult to visualize what the styled data will look like when I export it from Dropchop.

@mapsam
Copy link
Member Author

mapsam commented Jun 17, 2015

Good point. I'm going to push back a little on this one, just because doing this styling stuff is what's getting me excited right now. Since everything is broken into the _variables.scss file we can make changes quickly. We could even allow the user to switch between bold/light versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants