Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2/3/4/8-man 3x3 Blindfolded relay icons #107

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

dmint789
Copy link
Contributor

@dmint789 dmint789 commented Sep 8, 2023

This fulfills part of #105. Preview:

333bf

@dmint789 dmint789 mentioned this pull request Sep 8, 2023
Copy link
Member

@jfly jfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons seems reasonable to me, but let's come up with less cryptic names for these icons.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

@jfly how about 333bf-Nman-relay, where N is the number of people?

@jfly
Copy link
Member

jfly commented Sep 8, 2023

how about 333bf-Nman-relay, where N is the number of people

I like this, although we should avoid dashes, as those are our folder delimiter in this repo.

@lgarron, thoughts? Sure would be nice to have a better word than "man". "cuber"? "person"?

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

@jfly But mirror blocks uses dashes

@jfly
Copy link
Member

jfly commented Sep 8, 2023

although we should avoid dashes, as those are our folder delimiter in this repo

Nevermind, you reminded me here that we're already using kebab case. Let's stay consistent!

@lgarron
Copy link
Member

lgarron commented Sep 8, 2023

although we should avoid dashes, as those are our folder delimiter in this repo

Nevermind, you reminded me here that we're already using kebab case. Let's stay consistent!

That was mostly to match existing CSS names.

I would be more favor of underscores if we're okay with mixed hyphens and underscores in CSS. (I'm probably the only one using the mirror blocks icon, so renaming it is not a big concern).

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

I would prefer to either have everything in snake_case or everything in kebab-case, so if renaming mirror works, then we can go with that. We can just keep a duplicate with kebab-case so as not to break other people's stuff.

@lgarron
Copy link
Member

lgarron commented Sep 8, 2023

@lgarron, thoughts? Sure would be nice to have a better word than "man". "cuber"? "person"?

Definitely in favor of "person"! That's also what the WCA website uses.

I'd go with 333_bld_N_person_relay.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

That is so long, can we not think of something more elegant? How about 333bf_Np_relay? I strongly believe we should keep 333bf in the front, since it's just an extension of the 3x3 Blindfolded event.

@lgarron
Copy link
Member

lgarron commented Sep 8, 2023

I'm fine with 333bf as a prefix to keep some consistency with the existing event, but I definitely don't consider short names elegant. I think it's much more valuable for the name to make sense without context, and I struggle to think of a situation where 333bf_N_person_relay would fundamentally cause issues.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

Okay, I agree. Although seeing as we now have two icons with kebab-case it seems like it would make more sense to use that here too.

@lgarron
Copy link
Member

lgarron commented Sep 8, 2023

Also, just checking: do all four of these events correspond to relays that people actually do?

I am generally in favor of erring on the side of too many icons, but it could be wise to encourage a slimmer set of choices to start.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

Also, just checking: do all four of these events correspond to relays that people actually do?

I am generally in favor of erring on the side of too many icons, but it could be wise to encourage a slimmer set of choices to start.

These are all popular categories. There is also 5-man and 10-man, but I have seen very few of those. Feel free to have a look at the cubingcontests.com rankings for these events. And that is just what I've found so far.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

@jfly I think this is all done too now

@jfly jfly merged commit cdda991 into cubing:main Sep 8, 2023
1 check passed
@jfly
Copy link
Member

jfly commented Sep 8, 2023

Thanks!

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

Yay, now I can use more icons! I will work on team factory and 3x3 oh bld team relay icons tomorrow, I suppose.

@dmint789 dmint789 deleted the 333team-relay-icons branch September 8, 2023 21:03
@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

@jfly how long does it take until a new version is rolled out, and how does that process work?

@jfly
Copy link
Member

jfly commented Sep 8, 2023

I can do a release if that helps you. We don't really have a process around this.

@dmint789
Copy link
Contributor Author

dmint789 commented Sep 8, 2023

I see. Let's do it after I add the other two icons, so I'm not bothering you over and over again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants