Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade nodemailer from 6.7.5 to 6.9.9 #111

Closed
wants to merge 1 commit into from

Conversation

ank1traj
Copy link
Contributor

@ank1traj ank1traj commented Feb 1, 2024

PR 111 ank1traj Test plan 8978 Completed Powered by Pull Request Badge

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Priority Score (*) Issue Breaking Change Exploit Maturity
medium severity 658/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-JS-NODEMAILER-6219989
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Commit messages
Package name: nodemailer The new version differs by 51 commits.
  • 5a2e10f chore(master): release 6.9.9 [skip-ci] (#1606)
  • dd8f5e8 fix(security): Fix issues described in GHSA-9h6g-pr28-7cqp. Do not use eternal matching pattern if only a few occurences are expected
  • 2c2b46a chore: do not use caret in version specifier
  • be45c1b fix(tests): Use native node test runner, added code coverage support, removed grunt (#1604)
  • 4233f6f chore(master): release 6.9.8 [skip-ci] (#1605)
  • 09d502f chore: removed double file
  • b4d0e0c fix(punycode): do not use native punycode module
  • 8376c02 Test new github notice syntax for README
  • bc46a3b Updated stale github action
  • 78bdaf8 chore: remove redundant AWS SDK for JavaScript v2 (#1593)
  • 971ced7 chore: add mailcatch.app to well-known/services.json (#1586)
  • 879e562 chore(master): release 6.9.7 [skip-ci] (#1585)
  • 140e3b0 Merge branch 'master' of github.com:nodemailer/nodemailer
  • 41d482c fix(customAuth): Do not require user and pass to be set for custom authentication schemes (fixes #1584)
  • 20e9fe0 update - `services.json` - add SES SMTP endpoints for the AP region (#1580)
  • 9da77b6 chore(master): release 6.9.6 [skip-ci] (#1578)
  • 7fe0a60 fix(tests): Removed Node v12 from test matrix as it is not compatible with the test framework anymore
  • db32c93 fix(inline): Use 'inline' as the default Content Dispostion value for embedded images
  • fdc7c27 chore(master): release 6.9.5 [skip-ci] (#1573)
  • da4744e fix(license): Updated license year
  • 13672b2 Removed legacy files (#1571)
  • afd2287 Added release workflow to publish npm packages from Github
  • 1ae83a2 Update services.json
  • 286dc28 v6.9.4

See the full diff

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Copy link

coderabbitai bot commented Feb 1, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • package-lock.json is excluded by: !**/*.json
  • package.json is excluded by: !**/*.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@ghost
Copy link

ghost commented Feb 1, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

Copy link

stale bot commented Apr 10, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 10, 2024
@stale stale bot closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants