feat: remove Bouncy Castle dependencies #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
reviewed
Nov 18, 2024
pom.xml
Outdated
| <version>${bouncycastle.version}</version> | ||
| <groupId>com.hierynomus</groupId> | ||
| <artifactId>asn-one</artifactId> | ||
| <version>0.6.0</version> |
There was a problem hiding this comment.
Sure, I have just removed the bouncycastle.version property and added the asn.one.version property
brusdev
force-pushed
the
remove_bouncy_castle_deps
branch
from
20208c7 to
fd51f76
Compare
brusdev
force-pushed
the
remove_bouncy_castle_deps
branch
from
fd51f76 to
e94fde6
Compare
|
Thanks for the PR. Just to summarize this: The idea is to remove any cryptographic dependencies, because this dependency/keystore doesn't actually do any crypto stuff. It only required to read keys. That's what bouncycastle was used for. However, pulling in BC brings in additional functionality that isn't actually used. So the idea is to focus on the key parsing (ASN.1) and drop all other crypto stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the Bouncy Castle dependencies simplifies the adoption of pem-keystore in projects that can only use approved cryptographic modules.