support shell completion #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
approved these changes
Jan 23, 2025
|
Looks like some formatting issues. Also, it would be great if you could add a conventional commit message. So that the change shows up as a new feature. |
emouty
force-pushed
the
support-completion
branch
from
7d00328 to
7934788
Compare
|
The commit messages should be compliant now, could you rerun the ci workflow to check if everything is good ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4
Here is a proposal to support static completion for bash, zsh and fish. Dynamic completion is still in progress on clap side (see clap-rs/clap#3166) so that will be for later