Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort order and default attribute option #8

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

mblarsen
Copy link

Added the option to specify a default attribute option for select type (only):

options:
  - S
  - M
  - L|default
  - XL

The old implementation would not take into account the sort order.

Additionally unified: insert, update, delete into one process

@chevli
Copy link
Contributor

chevli commented Jan 25, 2016

Hi @mblarsen,

We have just made a major update to configurator. Would you be able to resolve any conflicts in the code and pass it over?

Many thanks :)

@mblarsen
Copy link
Author

@chevli sure I'll look into it

@mblarsen
Copy link
Author

I've merged master-branch now. Great work by the way.

@mblarsen
Copy link
Author

@chevli btw, your code will use the following code to set backend_type which is fine:

 $data['backend_type'] = $attribute->getBackendTypeByInput($data['frontend_input']);

However this value is easily be added to the yaml-file which gives you a load of trouble if you don't know what you are doing.

I didn't: http://magento.stackexchange.com/questions/98279/option-false-for-configurable-associated-products-imported-with-magmi

Perhaps it would be wise to throw an exception for types: dropdown, multiselect if it is not int
There might be other backend types that shouldn't be messed with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants