Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: fixed sql injection #52

Merged
merged 4 commits into from
May 6, 2024
Merged

Feature: fixed sql injection #52

merged 4 commits into from
May 6, 2024

Conversation

stevem-zhou
Copy link
Contributor

@stevem-zhou stevem-zhou commented May 1, 2024 •
edited
Loading

Parsed the numDonations and pageNum query so that it only takes an Int instead of a String before adding it to the SQL query.

  • tab query should be safe since it's being used as a way to access the tabStatuses map, it's not directly being used in a SQL query

@stevem-zhou stevem-zhou requested a review from jrock-3 May 1, 2024 22:04
jrock-3
jrock-3 approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@jrock-3 jrock-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jrock-3 jrock-3 merged commit ab24877 into dev May 6, 2024
2 of 3 checks passed
@jrock-3 jrock-3 deleted the fix-sql-injection branch May 6, 2024 05:17
@benjaminJohnson2204 benjaminJohnson2204 mentioned this pull request May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrock-3 jrock-3 jrock-3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevem-zhou @jrock-3