Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib/editor/atto/plugins/fontsize v2023091901 as submodule. #2

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

ctam
Copy link
Owner

@ctam ctam commented Jun 6, 2024

No description provided.

@ctam ctam merged commit a8fb9ac into UCSFCLE_403_STAGING Jun 6, 2024
3 checks passed
@ctam ctam deleted the ucsfcle_403_devel-moodle-atto_fontsize branch June 6, 2024 02:50
ctam pushed a commit that referenced this pull request Aug 31, 2024
This commit includes more changes, all them also adding the :void
return type to unit tests missing them.

The difference is that all these changes, while also detected
perfectly by the moodle.PHPUnit.TestReturnType sniff, were not
auto-fixed (like the previous commit ones), because all them
do include some "return" statement and, for safety, we don't
fix them.

All the cases have been visually inspected and confirmed that
the existing "return" statements always belong to anon
functions within the test body and not the test own return statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant