Magic MC support #5
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 18, 2023 18:40
"to_numpy()" otherwise).
… position instead of the averaged one. Required for cases when telescope postion in MC is not fixed (e.g. for MAGIC).
complex for Pandas.
MCSample; possibly needs to be revised)
added 3 commits
October 24, 2023 13:48
simulation loading).
…elescope position instead of the averaged one." This reverts commit 1704aba. Reason: commit breaks the MCSample.dndo() logic, which needs to be substantially revised before implementing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for MAGIC Monte Carlo files via ROOT -> HDF5 converter.
Changes:
magic_to_dl2converter to transform the MAGIC ROOT-format MC files ("Melibea" level) to minimally necessary DL2-level HDF5. Optionally splits MC into "pointings" following a HEALPix grid of the specified resolution, which allows to keep the rest of the simulation logic (largely based on SimTel fixed pointing approach) intact;Presently missing: