Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Effective Area 3D #281

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Effective Area 3D #281

wants to merge 24 commits into from

Commits on Feb 12, 2024

  1. Add 2 methods to calculate effective area in energy and 2 spacial dim… 

    …ensions

The different methods use binning in different coordinate systems
 - effective_area_3D_polar uses a polar coordinate system with radial FOV offset and azimuthal FOV position angle bins
 - effective_area_3D_nominal uses a nominal coordinate system with FOV longitude and FOV latitude bins
    Luca Di Bella authored and Luca Di Bella committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    14b050e View commit details
    Browse the repository at this point in the history

  2. Add methods to calculate n_showers in energy and 2 spacial dimensions 

    These calculate the number of showers in each bin for different coordinate systems
 - calculate_n_showers_3D_polar uses a polar coordinate system with radial FOV offset bins and azimuthal FOV position angle bins
 - calculate_n_showers_3D_nominal uses a nominal coordinate system with FOV longitude and latitude bins
    Luca Di Bella authored and Luca Di Bella committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3d80615 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'cta-observatory:main' into effective_area_3d

    @luca-dib
    luca-dib authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    bca9226 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Add util for calculating FOV position angle

    Luca Di Bella authored and Luca Di Bella committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    6b6ec8d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'effective_area_3d' of https://github.com/luca-dib/pyirf … 

    …into effective_area_3d
    Luca Di Bella authored and Luca Di Bella committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    52f4e44 View commit details
    Browse the repository at this point in the history

  3. Fix effective_area_3d and poition angle util

    Luca Di Bella authored and Luca Di Bella committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8056f6e View commit details
    Browse the repository at this point in the history

  4. Fix missing comma

    Luca Di Bella authored and Luca Di Bella committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7e0a1d3 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Fix typos causing error when calling calculate_n_showers_3d_*

    Luca Di Bella authored and Luca Di Bella committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4d5df74 View commit details
    Browse the repository at this point in the history

  2. Remove redundant argument breaking calculate_n_showers_3d call

    Luca Di Bella authored and Luca Di Bella committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    34ecab9 View commit details
    Browse the repository at this point in the history

  3. Fix formatting and issues from pull request Effective Area 3D (no. 28… 

    …1) code review
    Luca Di Bella authored and Luca Di Bella committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    2a6d047 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. Add functions to transform from sky coordinates to FOV coordinates

    Luca Di Bella authored and Luca Di Bella committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    8e4da8b View commit details
    Browse the repository at this point in the history

  2. Update calculate_n_showers_3d functions and add tests

    Luca Di Bella authored and Luca Di Bella committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    5e170e4 View commit details
    Browse the repository at this point in the history

  3. Fix position angle function, add rectangle solid angle function and t… 

    …ests
    Luca Di Bella authored and Luca Di Bella committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    98da953 View commit details
    Browse the repository at this point in the history

  4. Update effective area 3D functions and add corresponding tests

    Luca Di Bella authored and Luca Di Bella committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    f27eef8 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Fix code review issues

    Luca Di Bella authored and Luca Di Bella committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    777c0b1 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Update function names in __all__

    Luca Di Bella authored and Luca Di Bella committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    44018bc View commit details
    Browse the repository at this point in the history

  2. Fix all changed occurences of gadf coordinate function calls

    Luca Di Bella authored and Luca Di Bella committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c80ef58 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'cta-observatory:main' into effective_area_3d

    @luca-dib
    luca-dib authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    643958a View commit details
    Browse the repository at this point in the history

  2. Change az/alt to lon/lat due to support of both AltAz and ICRS

    Luca Di Bella authored and Luca Di Bella committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    d74bd18 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'effective_area_3d' of https://github.com/luca-dib/pyirf … 

    …into effective_area_3d
    Luca Di Bella authored and Luca Di Bella committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    554ef57 View commit details
    Browse the repository at this point in the history

  4. Add newsfragment

    Luca Di Bella authored and Luca Di Bella committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    8ff9e70 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Properly handle viewcone_min > 0, add docstring

    Luca Di Bella authored and Luca Di Bella committed May 2, 2024
    Configuration menu
    Copy the full SHA
    be14460 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Add missing condition to all_outside check

    Luca Di Bella authored and Luca Di Bella committed May 14, 2024
    Configuration menu
    Copy the full SHA
    af8a9d1 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. Merge branch 'cta-observatory:main' into effective_area_3d

    @luca-dib
    luca-dib authored May 17, 2024
    Configuration menu
    Copy the full SHA
    af76243 View commit details
    Browse the repository at this point in the history