Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added longitudinal fit parameters to 7.xx event end fields #37

Conversation

AndreaNegro953
Copy link
Contributor

The 74100 file actually has all 0 in the space I am reading but that happens also for the longitudinal chi2 field that was already present in the origin version of pycorsikaio.

@AndreaNegro953
Copy link
Contributor Author

The test on the units of the event end seems to be the problem, need to figure out why since I had no errors on my machine.

@maxnoe
Copy link
Member

maxnoe commented Nov 23, 2023

@AndreaNegro953 The test should fail the same locally. The issue is that event_end_fields now is a dict mapping version numbers to the actual fields, not the fields directly anymore.

You need to adapt the test loop over the versions and check all of them.

@AndreaNegro953
Copy link
Contributor Author

@maxnoe Really strange then, I got only warnings about a deprecated thing of numpy, probably I messed something up when running pytest. Anyway I will fix the problem as soon as I can.

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eef3b78) 95.89% compared to head (afa6a44) 95.48%.
Report is 2 commits behind head on main.

Files Patch % Lines
corsikaio/subblocks/event_end.py 84.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   95.89%   95.48%   -0.41%     
==========================================
  Files          20       20              
  Lines         609      643      +34     
==========================================
+ Hits          584      614      +30     
- Misses         25       29       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member

maxnoe commented Nov 23, 2023

Can you produce a small test file that contains values for these fields and check they are read correctly?

@AndreaNegro953
Copy link
Contributor Author

Of course, maybe for that I need a little bit more time.

@maxnoe
Copy link
Member

maxnoe commented Nov 24, 2023

@AndreaNegro953 I was able create a suitable test file.

Should I just add it here to your branch?

@AndreaNegro953
Copy link
Contributor Author

Sorry if I did not reply earlier
Thank you for providing a test file, are there other things I should add to this pull request?

@maxnoe
Copy link
Member

maxnoe commented Nov 27, 2023

@AndreaNegro953 No, it looks good! Thanks a lot!

@maxnoe maxnoe merged commit bdf5174 into cta-observatory:main Nov 27, 2023
4 of 6 checks passed
@AndreaNegro953
Copy link
Contributor Author

@maxnoe Me and @HealthyPear need to use the parameters added in this PR, would be possible to do a minor release to make this commit available?

@maxnoe
Copy link
Member

maxnoe commented Nov 27, 2023

@AndreaNegro953 Yes, I was planning to make a new release together with #39, should be out today

@AndreaNegro953
Copy link
Contributor Author

@maxnoe Thank you!

@maxnoe
Copy link
Member

maxnoe commented Nov 27, 2023

@AndreaNegro953 corsika 0.4 is on PyPI: https://pypi.org/project/corsikaio/, conda-forge package will come later today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants