-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added longitudinal fit parameters to 7.xx event end fields #37
Added longitudinal fit parameters to 7.xx event end fields #37
Conversation
The test on the units of the event end seems to be the problem, need to figure out why since I had no errors on my machine. |
@AndreaNegro953 The test should fail the same locally. The issue is that You need to adapt the test loop over the versions and check all of them. |
@maxnoe Really strange then, I got only warnings about a deprecated thing of numpy, probably I messed something up when running pytest. Anyway I will fix the problem as soon as I can. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #37 +/- ##
==========================================
- Coverage 95.89% 95.48% -0.41%
==========================================
Files 20 20
Lines 609 643 +34
==========================================
+ Hits 584 614 +30
- Misses 25 29 +4 ☔ View full report in Codecov by Sentry. |
Can you produce a small test file that contains values for these fields and check they are read correctly? |
Of course, maybe for that I need a little bit more time. |
@AndreaNegro953 I was able create a suitable test file. Should I just add it here to your branch? |
Sorry if I did not reply earlier |
@AndreaNegro953 No, it looks good! Thanks a lot! |
@maxnoe Me and @HealthyPear need to use the parameters added in this PR, would be possible to do a minor release to make this commit available? |
@AndreaNegro953 Yes, I was planning to make a new release together with #39, should be out today |
@maxnoe Thank you! |
@AndreaNegro953 corsika 0.4 is on PyPI: https://pypi.org/project/corsikaio/, conda-forge package will come later today |
The 74100 file actually has all 0 in the space I am reading but that happens also for the longitudinal chi2 field that was already present in the origin version of pycorsikaio.