Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configuration for src15 #500

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

nikoliclisa
Copy link
Contributor

@nikoliclisa nikoliclisa commented Oct 4, 2024

New Prod config

Self check-list:

  • I have checked the lstchain config, in particular for:
    • az_tel instead of sin_az_tel if data to be analyzed have been produced with lstchain <= v0.9.7
    • "increase_nsb" and "increase_psf" are provided in "image_modifier" (if used)
  • I have checked the environment in the lstmcpipe config and it is the one used to analyse DL>1 data
  • I have provided the command (in README), or script (in additionnal .py file) used to produce the lstmcpipe config

Prod_ID

Short description of the config

Why this config is needed

@nikoliclisa
Copy link
Contributor Author

Hi @vuillaut
Is there anything else that should be provided for the production?

"waveform_offset": 400,
"waveform_scale": 80
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikoliclisa
Sorry for the delay.
Thank you for the well documented readme.
The lstchain config should include the image_modifier config you produced.

@vuillaut
Copy link
Member

To not add any further delay, I have fixed the lstchain config and will start the production.

@vuillaut vuillaut merged commit 35e33a2 into master Oct 23, 2024
7 checks passed
@vuillaut vuillaut deleted the 20240917_v0.10.12_src15_dec_min_2924_tuned branch October 23, 2024 14:52
@vuillaut vuillaut restored the 20240917_v0.10.12_src15_dec_min_2924_tuned branch October 23, 2024 14:52
@vuillaut
Copy link
Member

@nikoliclisa
This configuration cannot work, it starts from a source prod 20240917_v0.10.12_src15_dec_min_2924_tuned that does not exist (it's yours).
You must start from an existing prod. In this case, the most recent base one is 20240131_allsky_v0.10.5_all_dec_base.
Please reproduce the config (you will need to pull the changes I made to lstchain config to be able to push again on that branch).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants