Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dla1b to take v0.9 dl1 files as input #1329

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

moralejo
Copy link
Collaborator

No description provided.

@moralejo moralejo requested a review from rlopezcoto December 19, 2024 15:52
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.48%. Comparing base (a328e44) to head (d84b83b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/scripts/lstchain_dl1ab.py 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1329      +/-   ##
==========================================
- Coverage   73.52%   73.48%   -0.04%     
==========================================
  Files         134      134              
  Lines       14215    14221       +6     
==========================================
  Hits        10451    10451              
- Misses       3764     3770       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lstchain/scripts/lstchain_dl1ab.py Show resolved Hide resolved
lstchain/scripts/lstchain_dl1ab.py Outdated Show resolved Hide resolved
@moralejo moralejo requested a review from morcuended January 9, 2025 15:20
@morcuended
Copy link
Member

Looks good to me now (if it is ready for review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants