Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tailcut finder function and script #1325

Open
wants to merge 33 commits into
base: main
Choose a base branch
from
Open

Tailcut finder function and script #1325

wants to merge 33 commits into from

Conversation

moralejo
Copy link
Collaborator

@moralejo moralejo commented Dec 16, 2024

Find adequate cleaning levels (and MC NSB tuning settings) to process a given run, just based on the pixel charges extracted from interleaved pedestal events. See #1330 for some tests of performance.

@moralejo
Copy link
Collaborator Author

@marialainez, @morcuended this is still a draft (I am testing it), but it would be good if you can already comment on the interface, since this is mainly to use by lstosa

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 23.01587% with 97 lines in your changes missing coverage. Please review.

Project coverage is 73.05%. Comparing base (9aaa78b) to head (9f344d4).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lstchain/image/cleaning.py 17.85% 69 Missing ⚠️
lstchain/scripts/lstchain_find_tailcuts.py 33.33% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   73.52%   73.05%   -0.48%     
==========================================
  Files         134      135       +1     
  Lines       14215    14323     +108     
==========================================
+ Hits        10451    10463      +12     
- Misses       3764     3860      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…itional NSB needed in the MC.

Previous ones were based on the mean pedestal charges, with no exclusion
of outliers (pixels or subruns). New ones are based on the medians computed
in the current code (& excluding outliers)
@moralejo moralejo marked this pull request as ready for review December 17, 2024 16:25
…to the

old version using mean pedestal chages (and including outliers). New ones
are adapted to the new definitions (medians, no outliers) and consistent
with the MC productions
@moralejo moralejo marked this pull request as draft December 19, 2024 08:56
@moralejo
Copy link
Collaborator Author

Converted to draft just because I merged all changes in main, which now appear as part of this PR ( :-( )

@moralejo moralejo marked this pull request as ready for review December 19, 2024 10:25
@moralejo moralejo marked this pull request as draft December 19, 2024 16:32
pixels, but truncating the charge distribution of all pixels (hence biasing
the result)
(to those obtained with the proper pixel outlier exclusion in MC)
…e, which

characterizes better the right-side tail of the distribution (more relevant for
the analysis)
@moralejo moralejo marked this pull request as ready for review December 21, 2024 08:57
@moralejo moralejo requested a review from vuillaut December 21, 2024 08:57
@moralejo
Copy link
Collaborator Author

This is now ready for review; performance results and some further explanations are shown in #1330

@moralejo
Copy link
Collaborator Author

Below is the correlation between the outputs of find_tailcuts, picture threshold vs. additional NSB rate, compared to the settings of the recently produced standard MC simulation NSB grid.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants