-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tailcut finder function and script #1325
base: main
Are you sure you want to change the base?
Conversation
Just based on mean pedestal charge in interleaved pedestals, and using tabulated data (and a parametrization of NSB level vs <ped charge>)
Improved docstrings
@marialainez, @morcuended this is still a draft (I am testing it), but it would be good if you can already comment on the interface, since this is mainly to use by lstosa |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
- Coverage 73.52% 73.05% -0.48%
==========================================
Files 134 135 +1
Lines 14215 14323 +108
==========================================
+ Hits 10451 10463 +12
- Misses 3764 3860 +96 ☔ View full report in Codecov by Sentry. |
…itional NSB needed in the MC. Previous ones were based on the mean pedestal charges, with no exclusion of outliers (pixels or subruns). New ones are based on the medians computed in the current code (& excluding outliers)
…with cleaning settings. This is now doe by the new script lstchain_find_tailcuts.py
…to the old version using mean pedestal chages (and including outliers). New ones are adapted to the new definitions (medians, no outliers) and consistent with the MC productions
Converted to draft just because I merged all changes in main, which now appear as part of this PR ( :-( ) |
58805ed
to
7486271
Compare
e6fc390
to
7486271
Compare
pixels, but truncating the charge distribution of all pixels (hence biasing the result)
(to those obtained with the proper pixel outlier exclusion in MC)
…e, which characterizes better the right-side tail of the distribution (more relevant for the analysis)
This is now ready for review; performance results and some further explanations are shown in #1330 |
Find adequate cleaning levels (and MC NSB tuning settings) to process a given run, just based on the pixel charges extracted from interleaved pedestal events. See #1330 for some tests of performance.