shellcheck: use a new version of run-shellcheck.sh
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 12, 2024
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 12, 2024
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 13, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 26, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
lzaoral
reviewed
Aug 26, 2024
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 26, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
... initially developed for Konflux CI. The updated version runs more processes of `shellcheck` in parallel, each of them with a strictly set timeout (currently 30s of wall-clock time). Related: https://issues.redhat.com/browse/OSH-655 Resolves: https://issues.redhat.com/browse/OSH-733
... that do not support `--format=json1`. Related: https://issues.redhat.com/browse/OSH-655
... so that we get equivalent scan results as if we scanned all scripts at once. Related: https://issues.redhat.com/browse/OSH-655
... so that we get equivalent scan results as if we scanned all scripts at once. Related: https://issues.redhat.com/browse/OSH-655
... to configure maximum amount of wall-clock time taken by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655
... to configure maximum number of scripts scanned by a single shellcheck process Related: https://issues.redhat.com/browse/OSH-655
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 26, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
lzaoral
approved these changes
Aug 26, 2024
jamacku
reviewed
Aug 26, 2024
|
@kdudka What about adding a simple ShellCheck test to CI? diff --git a/tests/simple_build/shellcheck.fmf b/tests/simple_build/shellcheck.fmf
new file mode 100644
index 0000000..f73f614
--- /dev/null
+++ b/tests/simple_build/shellcheck.fmf
@@ -0,0 +1,11 @@
+summary: Test analysis using GCC analyzer
+test: ./test.sh
+framework: beakerlib
+environment:
+ TEST_PACKAGE: dracut
+ TEST_TOOL: shellcheck
+component:
+ - csmock
+recommend:
+ - csmock
+duration: 1h |
kdudka
added a commit
to kdudka/csmock
that referenced
this pull request
Aug 26, 2024
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Also remove the filter for `note` events, which were specific to the `gcc` output of ShellCheck. Related: https://issues.redhat.com/browse/OSH-655 Closes: csutils#182
|
@kdudka The following patch should fix the test failures on C9S hosts: diff --git a/tests/simple_build/test.sh b/tests/simple_build/test.sh
index 9c0106e..3e684da 100755
--- a/tests/simple_build/test.sh
+++ b/tests/simple_build/test.sh
@@ -7,6 +7,10 @@ TEST_PACKAGE="${TEST_PACKAGE:-}"
TEST_TOOL="${TEST_TOOL:-}"
TEST_USER="csmock"
+# Add CS Koji
+BEAKERLIB_rpm_fetch_base_url+=( "https://kojihub.stream.centos.org/kojifiles/packages/" )
+BEAKERLIB_rpm_packageinfo_base_url+=( "https://kojihub.stream.centos.org/koji/" )
+
rlJournalStart
rlPhaseStartSetup
# use the latest csutils in the Testing Farm
|
... so that we get equivalent scan results to the old version of the shellcheck plug-in. Also remove the filter for `note` events, which were specific to the `gcc` output of ShellCheck. Related: https://issues.redhat.com/browse/OSH-655
|
Thanks for review and testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... initially developed for Konflux CI. The updated version runs more processes of
shellcheckin parallel, each of them with a strictly set timeout (by default 30s of wall-clock time).Related: https://issues.redhat.com/browse/OSH-655
Resolves: https://issues.redhat.com/browse/OSH-733