snyk: do not throw away Snyk results by mistake #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... on successful scans. This commit fixes a major regression introduced by the previous commit. Fixes: commit e886342 Related: https://issues.redhat.com/browse/OSH-329 Resolves: https://issues.redhat.com/browse/OSH-362 Closes: csutils#133
kdudka
force-pushed
the
snyk-missing-results
branch
from
9576645
to
e1a73c6
Compare
|
@kdudka @jperezdealgaba Thank you both for the quick fix! It may be a good idea to extend the changes done in #95 with a follow up PR to also test the Snyk Also, @jperezdealgaba, please, make sure to test your contributions properly. I'm sure that you have tested that the original PR fixed the crash reproducer but it is a very good practice to also check that the basic common use cases won't be affected by your changes and that they still work and produce reasonable results. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... on successful scans. This commit fixes a major regression introduced by the previous commit.
Fixes: commit e886342
Related: https://issues.redhat.com/browse/OSH-329
Resolves: https://issues.redhat.com/browse/OSH-362