Add calendar to mentor attendance view #475
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csm_web
|
||||||||||||||||||||||||||||||||||||||||
| Project |
csm_web
|
| Branch Review |
feat/mentor-attendance-calendar
|
| Run status |
|
| Run duration | 02m 23s |
| Commit |
|
| Committer | Alec Li |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
2
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
76
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/section/mentor-section.cy.ts • 1 failed test • Tests on Chrome
| Test | Artifacts | |
|---|---|---|
| attendances > should be able to navigate to and view section attendances |
Test Replay
Screenshots
|
|
cypress/e2e/section/mentor-section.cy.ts • 1 failed test • Tests on Firefox
| Test | Artifacts | |
|---|---|---|
| attendances > should be able to navigate to and view section attendances |
Screenshots
|
|
smartspot2
force-pushed
the
feat/mentor-attendance-calendar
branch
from
8d149c9
to
f62efe4
Compare
smartspot2
force-pushed
the
feat/mentor-attendance-calendar
branch
from
f62efe4
to
44ce955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current calendar has a few annoyances, which could benefit from some QOL improvements.
In particular, the date selection is a horizontal scroll at the top, which is not the easiest to navigate---users are more used to vertical tabs, especially in situations where there are many options, as horizontal scrolling becomes unwieldy. In this new version of the page, the tabs are displayed vertically, on the left of the attendance form.
Additionally, a calendar has been added for better visual representation and selection of the attendance date. This calendar also provides some information about attendance history at a glance, listing the number of present students out of the total students for every section occurrence. The calendar can be toggled on or off with a button on the top left of the container.
Old calendar:
New calendar:
