Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleanup #28

Merged
merged 2 commits into from
Dec 9, 2024
Merged

Feature/cleanup #28

merged 2 commits into from
Dec 9, 2024

Conversation

jlerat
Copy link
Collaborator

@jlerat jlerat commented Dec 8, 2024

No description provided.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.87%. Comparing base (bf28d4a) to head (aec110c).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
src/hydrodiy/data/dutils.py 61.11% 6 Missing and 1 partial ⚠️
src/hydrodiy/data/containers.py 76.19% 3 Missing and 2 partials ⚠️
src/hydrodiy/data/qualitycontrol.py 75.00% 1 Missing and 1 partial ⚠️
src/hydrodiy/data/signatures.py 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
+ Coverage   81.65%   84.87%   +3.21%     
==========================================
  Files          29       23       -6     
  Lines        4617     4323     -294     
  Branches      733      628     -105     
==========================================
- Hits         3770     3669     -101     
+ Misses        562      379     -183     
+ Partials      285      275      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlerat jlerat merged commit 4ca289d into master Dec 9, 2024
2 of 3 checks passed
@jlerat jlerat deleted the feature/cleanup branch December 9, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant