Improve build and test processes #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5542e06. The filenames on my local Windows machine differ from those generated through GitHub Actions.
Currently, there's a gfortran installed by (I think) chocolatey that's being used to build the project.
Setting CMAKE_Fortran_COMPILER got the correct compiler!
I swear I read the docs.
This reverts commit 820d8ce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a build error with flang 19.0.* on Windows (I was creating
bmif_2_0.medtwice, once each with the shared and the static library). I solved this using a CMake object library as a base to build the shared and static libraries.Another problem (that I've also seen elsewhere): the Windows platform used by Actions includes a gcc install with gfortran, and this gfortran is always found first in the path, before the flang installed in the
testingconda environment. I solved this by setting theCMAKE_Fortran_COMPILERvariable to the path to flang-new.exe in the conda environment.Last, I switched build backends from NMake Makefiles to Ninja, which is what we use in our Meson-based projects.