Fix lost focus on page load due to false equivalency check #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dn't early-exit on first run, due to selText being undefined, rather than null. Coerce selText to boolean to catch this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus was being cleared via selection.empty() since clearHighlight didn't early-exit on first run, due to selText being undefined rather than null. Coerce selText to Boolean to catch this case.
Focus is still lost when character highlighting is done, which seems like unintended behaviour. To make that better I'd suggest storing the carat position and using Selection.collapse(ToEnd|ToStart).