fix bad error-messaging

[k9ert]

In the case of using spectrum, errors which came from the electrum server, did not got shown very well to the user.
In one case we had

This is caused by the server not returning json which in turn is caused by the client not adding "Accept:application/json" to the header. Also the errorClass translation from electrum -> spectrum -> specter-ext -> specter -> user was quite improvable.

[netlify]

✅ Deploy Preview for specter-desktop-docs canceled.

Name	Link
🔨 Latest commit	b24a2c1
🔍 Latest deploy log	https://app.netlify.com/sites/specter-desktop-docs/deploys/66466b77b7ae640008373b69

[moneymanolis]

@k9ert can we remove these console.logs in this PR before the release:

specter-desktop/src/cryptoadvance/specter/templates/includes/hwi/components/wallet.jinja

Line 51 in 714a8ae

console.log(signedTx);

especially the console log of the PSBT should be removed, what do you think?

[moneymanolis]

getting this error right now when using 1 sat / vbyte fee on testnet:

[2024-05-15 19:11:01,406] ERROR in controller: Uncaught exception: string indices must be integers
[2024-05-15 19:11:01,410] ERROR in controller: Traceback (most recent call last):
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask/app.py", line 1823, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask/app.py", line 1799, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask_login/utils.py", line 290, in decorated_view
    return current_app.ensure_sync(func)(*args, **kwargs)
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/server_endpoints/wallets/wallets_api.py", line 182, in broadcast
    app.specter.broadcast(tx)
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/specter.py", line 513, in broadcast
    res = self.rpc.sendrawtransaction(raw)
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/rpc.py", line 507, in fn
    r = self.multi([(method, *args)], **kwargs)[0]
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specterext/spectrum/bridge_rpc.py", line 102, in multi
    result = [
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specterext/spectrum/bridge_rpc.py", line 103, in <listcomp>
    self.spectrum.jsonrpc(
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/cryptoadvance/spectrum/spectrum.py", line 499, in jsonrpc
    raise e
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/cryptoadvance/spectrum/spectrum.py", line 489, in jsonrpc
    res = m(*args, **kwargs)
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/cryptoadvance/spectrum/spectrum.py", line 56, in wrapper
    return f(*args, **kwargs)
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/cryptoadvance/spectrum/spectrum.py", line 716, in sendrawtransaction
    res = self.sock.call("blockchain.transaction.broadcast", [hexstring])
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/cryptoadvance/spectrum/elsock.py", line 564, in call
    raise RPCError(res["error"]["message"], res["error"]["code"])
TypeError: string indices must be integers

[moneymanolis]

@k9ert do we perhaps have to parse the JSON string into a dictionary correctly?

We should in any case better check whether res is a dict and not just a string with sth. like:

if isinstance(res, dict) and "error" in res:
    error = res.get("error", {})
    error_code = error.get("code")
    error_message = error.get("message")
    if error_code is not None and error_message is not None:
        raise RPCError(error_message, error_code)
    else:
        raise SpectrumInternalException(res)

[k9ert]

especially the console log of the PSBT should be removed, what do you think?

Happy to remove them but they are not part of this PR so maybe we can do that in some other PR.

[k9ert]

Can't reproduce the "TypeError: string indices must be integers" issue. But i implemented your proposal anyway here:
cryptoadvance/spectrum#55
Please approve and i create yet another Spectrum release and use it here.

[moneymanolis]

I could broadcast with Spectrum and 1 sat fee on testnet without error now (might be that we are catching it now gracefully, which might be fine since it aligns with bitcoind).