Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Signing Support & TxDecoder #298

Merged
merged 280 commits into from
Aug 10, 2021
Merged

Offline Signing Support & TxDecoder #298

merged 280 commits into from
Aug 10, 2021

Conversation

cdc-Hitesh
Copy link
Contributor

No description provided.

cdc-Hitesh and others added 30 commits May 29, 2021 15:23
Problem: Feature offline signing msg send
Fix test case #247

- Typo fix
- bugfix #248
- MsgSetwithdrawal

-MsgSetWithdrawal support
- Eslint disable camelcase

MsgWithdrawValidatorCommission support
- CommunityPool
- ParameterChangeProposal
- Refactoring
Co-authored-by: Calvin Lau <[email protected]>
cdc-Hitesh and others added 18 commits July 30, 2021 17:55
Review 1: Eslint Fix | TxDecoder | OfflineSigning | IBCLightClient.ClientState
Review 2: Consensus State | TxDecoder Support | MsgCreateClient Fix | owTypes Fix
Review 3: MsgUpdateClient .toCosmosJSON | LightClient.Header
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 1 alert when merging 1624ff8 into 091d2bd - view on LGTM.com

new alerts:

  • 1 for Identical operands

cdc-Hitesh and others added 2 commits August 3, 2021 14:58
Review 4 `MsgConnectionOpenConfirm` support | TxDecoder | `MsgConnectionOpenTry` | fromCosmosJSON()
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 1 alert when merging c82b19b into 091d2bd - view on LGTM.com

new alerts:

  • 1 for Identical operands

@calvinaco calvinaco changed the title [NFM] [Review-3] : Offline Signing Support & TxDecoder Offline Signing Support & TxDecoder Aug 4, 2021
@cdc-Hitesh cdc-Hitesh marked this pull request as ready for review August 4, 2021 06:54
@cdc-Hitesh
Copy link
Contributor Author

@calvinaco @crypto-3dd
Can we review this pr for the final merge?

@calvinaco calvinaco merged commit 542f991 into dev Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants