Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Fixed compilation error with ambiguous of 'abs(int64_t)'. #186

Open
wants to merge 1,644 commits into
base: master
Choose a base branch
from
Open

Fixed compilation error with ambiguous of 'abs(int64_t)'. #186

wants to merge 1,644 commits into from

Conversation

nataliakoval
Copy link

No description provided.

[email protected] and others added 30 commits August 15, 2014 17:14
[SyncFS] Add last validate time in MDDB ver.4
5303625 
BUG=347425
TEST=None

Review URL: https://codereview.chromium.org/460503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289921 0039d316-1c4b-4281-b951-d872f2087c98
Gallery: Load gallery items by chunk on startup.
f16411e 
BUG=chrome-os-partner:28087
TEST=run on link

Review URL: https://codereview.chromium.org/470983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289922 0039d316-1c4b-4281-b951-d872f2087c98
Provide experimental AudioProcessing options at creation.
419761e 
Remove now unneeded MediaStreamAudioProcessorOptions setters. Removes
all calls to AudioProcessing::SetExtraOptions() from Chromium.

TESTED=verified that options are set correctly in AudioProcessing.
BUG=webrtc:3702

Review URL: https://codereview.chromium.org/470403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289923 0039d316-1c4b-4281-b951-d872f2087c98
Updating XTBs based on .GRDs from branch 2062
8ed87dd 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289925 0039d316-1c4b-4281-b951-d872f2087c98
[MemSheriff] Suppress leaks in app_list_unittests
dc20415 
BUG=404182
[email protected]

Review URL: https://codereview.chromium.org/478723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289927 0039d316-1c4b-4281-b951-d872f2087c98
Handle cr.exportPath() in compiler pass, declare every object only once
e05791d 
BUG=393873
[email protected],[email protected]
TEST=third_party/closure_compiler/runner/how_to_test_compiler_pass.md

Review URL: https://codereview.chromium.org/453783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289928 0039d316-1c4b-4281-b951-d872f2087c98
Add tests for gfx::ScreenRectTo/FromNSRect.
87a5679 
Tests are added for these coordinate conversion functions with various
simulated screen setups.

The recently moved ScopedObjCClassSwizzler in src/base/test is used so
that -[NSScreen frame] can be mocked to return a known value.

BUG=378134
TEST=gfx_unittests

Review URL: https://codereview.chromium.org/411833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289929 0039d316-1c4b-4281-b951-d872f2087c98
Allow to close the video player with ctrl-w.
637d547 
The regression was caused by a preventDefault() call.

TEST=Tested manually.
BUG=403002

Review URL: https://codereview.chromium.org/477033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289930 0039d316-1c4b-4281-b951-d872f2087c98
Added 'launcher_page' field to extension manifest.json format.
009187e 
Adds a new manifest section which allows extensions (currently, only
platform apps) to provide a page in the experimental app launcher, eg:

  "launcher_page": {
    "page": "index.html"
  }

All installed apps with a valid launcher_page section will be given a
page in the launcher.

This feature is currently only available on dev channel and whitelisted
(currently to a few testing apps; this list will expand in the future,
and can be overridden with --whitelisted-extension-id=ID).

Updated CustomLauncherPageBrowserTest to use its manifest to install the
launcher page, rather than using --custom-launcher-page.

BUG=399131,404000

Review URL: https://codereview.chromium.org/475543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289931 0039d316-1c4b-4281-b951-d872f2087c98
Video Player: Show favicon as task icon on Files.app
2d0367d 
BUG=401399
TEST=manual

Review URL: https://codereview.chromium.org/450943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289932 0039d316-1c4b-4281-b951-d872f2087c98
Disable RenderWidgetHostViewAuraTest.FullscreenResize since it fails …
6e75cd0 
…depending on the screen resolution.

BUG=324350
[email protected]

Review URL: https://codereview.chromium.org/476243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289933 0039d316-1c4b-4281-b951-d872f2087c98
Show no information on the preview panel when no item is selected.
43584fc 
In the updated UI, path information is moved from footer to toolbar, and only information about selected entries is displayed on the footer.
In open dialog, there is a case that the preview panel is visible and no item is selected.
This patch hide everything (thumbnail and entry name) from the footer when no item is selected.

BUG=402821
TEST=manually

Review URL: https://codereview.chromium.org/468913005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289934 0039d316-1c4b-4281-b951-d872f2087c98
Add metrics to the new ProfileChooser Tutorials
337c7ae 
Noms as TBR, the profile_metrics have been well reviewed by others.

BUG=401147

[email protected]

Review URL: https://codereview.chromium.org/470643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289935 0039d316-1c4b-4281-b951-d872f2087c98
Add owners for apps and app list related histograms
6ecb112 
BUG=404007

Review URL: https://codereview.chromium.org/475283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289936 0039d316-1c4b-4281-b951-d872f2087c98
Revert 289433 "Refactor pooling logic into a helper method"
8f8ea96 
Reason for revert:
Causes crashes in canary.

> Refactor pooling logic into a helper method
> Disable pooling when there are cert errors.
> Disable pooling when pinning does not match for the new host.
> 
> BUG=398925
> 
> Review URL: https://codereview.chromium.org/425803014

[email protected]

Review URL: https://codereview.chromium.org/476113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289937 0039d316-1c4b-4281-b951-d872f2087c98
Moving all the incident reporting stuff to a common folder
ecef9a0 
BUG=

Review URL: https://codereview.chromium.org/470213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289938 0039d316-1c4b-4281-b951-d872f2087c98
Add UMA stats for received frames or not in video track adapter.
739bd86 
The adapter is torn down when a session is ended (no more tracks connected to it), so we do the logging in the destructor.

BUG=399835

Review URL: https://codereview.chromium.org/466333005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289939 0039d316-1c4b-4281-b951-d872f2087c98
Roll WebRTC 6898:6905
f4c1cf4 
BUG=
[email protected]

Review URL: https://codereview.chromium.org/469423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289940 0039d316-1c4b-4281-b951-d872f2087c98
Refactor lazy JNI registration support.
f2eaf75 
Rename the "linker_script_copy" target to "android_exports" and move the
link_settings clause to that target. This avoids the linker flag being
duplicated once for every target which includes jni_generator.gypi,
which causes problems on some linker versions.

BUG=402003

Review URL: https://codereview.chromium.org/473173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289941 0039d316-1c4b-4281-b951-d872f2087c98
Update .DEPS.git
edc2857 
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289942 0039d316-1c4b-4281-b951-d872f2087c98
Add the strings for the new social engineering warning
2ede690 
BUG=397754

Review URL: https://codereview.chromium.org/469023003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289943 0039d316-1c4b-4281-b951-d872f2087c98
Mpeg2 TS - Fail when no valid timestamp in the ADTS parser.
788d9d5 
BUG=None

Review URL: https://codereview.chromium.org/399433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289944 0039d316-1c4b-4281-b951-d872f2087c98
Raise memory limit for SDCH for mobile.
b85943c 
[email protected]
BUG=374917

Review URL: https://codereview.chromium.org/471403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289945 0039d316-1c4b-4281-b951-d872f2087c98
Log NTP loading time separately for local, Google and other NTPs.
c49d960 
We currently use the same UMA metric to log the loading time of different kinds of NTP:
- The local NTP
- The Google app-cached NTP
- NTP from other providers

This CL separates these in three UMA metric using histogram suffixes.

In addition, this CL brings back the Tab.NewTab* UMA metrics to the public histograms.xml in accordance with the practice that metrics in the public chromium repository should be in the public histograms.xml.

Review URL: https://codereview.chromium.org/474053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289946 0039d316-1c4b-4281-b951-d872f2087c98
[MemSheriff] Disable WebRtcLocalAudioTrackTest.ConnectTracksToDiffere…
a68d37c 
…ntCapturers to get tsan bot green.

BUG=404133
[email protected]

Review URL: https://codereview.chromium.org/478693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289947 0039d316-1c4b-4281-b951-d872f2087c98
Cocoa extension install dialog instrumentation.
b22b1a9 
This adds Experience Sampling instrumentation to the Cocoa version of
the extension install dialog.

BUG=384635

Review URL: https://codereview.chromium.org/462853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289948 0039d316-1c4b-4281-b951-d872f2087c98
[Findit] Plain objects to represent the returned result from running …
4ef081b 
…the algorithm,

NOTRY=true

Review URL: https://codereview.chromium.org/421223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289949 0039d316-1c4b-4281-b951-d872f2087c98
Update DT_RELA* fields when packing relocations with addends.
15897b0 
If the shared libary being packed uses relocations with addends,
update DT_RELASZ and DT_RELACOUNT instead of DT_RELSZ and DT_RELCOUNT.
Check DT_RELAENT instead of DT_RELENT.

Update unit test data to match.

BUG=385553

Review URL: https://codereview.chromium.org/474283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289950 0039d316-1c4b-4281-b951-d872f2087c98
Add ability to active multiple devices via the audio API.
828f837 
Add the ability to the audio API to activate more than one audio device at a
time. This is currently accomplished via a hack and when getting device info
via audio.getInfo, only one device will show up as active.

This will allow us to active multiple microphones and multiple speakers though.

I've also made couple of changes to OWNERS files so we don't need to keep
chasing rubberstamps for audio changes.

This is patched from rkc@'s original cl:
https://codereview.chromium.org/460113003/

BUG=397664

TBR=asargent

Review URL: https://codereview.chromium.org/478493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289951 0039d316-1c4b-4281-b951-d872f2087c98
Copy resources from webkit/glue/resources over to content/app/resources.
7227c4d 
We need to copy these png images first because tryserver does not work
very well with binaries in patches. So in order to run the trybots in
the next CL, we need to copy them first.

BUG=338338
TEST=None
[email protected]
NOTRY=true

Review URL: https://codereview.chromium.org/471343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289954 0039d316-1c4b-4281-b951-d872f2087c98
@rakuco rakuco force-pushed the master branch 2 times, most recently from 5d9bef8 to 18a33ff Compare September 16, 2015 10:57
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
Revert of Pre-cache downloads directory path in PathUtils. (patchset #1…
32879e4 
… id:1 of https://codereview.chromium.org/1281273003/ )

Reason for revert:
Revert because it breaks new beta. See
https://code.google.com/p/chromium/issues/detail?id=528377

Original issue's description:
> Pre-cache downloads directory path in PathUtils.
>
> When Chrome tabs are swiped away and user starts Chrome again,
> their default downloads directory is requested. This causes a
> StrictMode policy violation since it results in a ~60ms disk
> read. Thus by adding this call to the initial AsyncTask we
> save that time when the directory is requested by native.
>
> This must only be called in the browser process as the sandbox
> processes do not need to make the call nor can they make the
> call(results in NPE).
>
> BUG=508615
>
> Committed: https://crrev.com/4a7568dffab924d3710a68949dca0717bdad3352
> Cr-Commit-Position: refs/heads/master@{#342672}

[email protected], [email protected]
[email protected], [email protected], [email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=508615

Review URL: https://codereview.chromium.org/1328043002

Cr-Commit-Position: refs/heads/master@{#347518}

Review URL: https://codereview.chromium.org/1315443012 .

Cr-Commit-Position: refs/branch-heads/2490@{#186}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
@rakuco rakuco force-pushed the master branch 2 times, most recently from 830d9f6 to 5ad5a18 Compare November 19, 2015 09:27
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
@fgorski
[Offline pages] Filter out offline pages without matching bookmarks i…
2f936d9 
…n UI

Making sure that when offline page filter is applied, all of the
bookmark IDs are checked against the bookmark model, before being
used by UI.

BUG=537806

Review URL: https://codereview.chromium.org/1470403002

Cr-Commit-Position: refs/heads/master@{#362185}
(cherry picked from commit f2d8e24)

Review URL: https://codereview.chromium.org/1486753005 .

Cr-Commit-Position: refs/branch-heads/2564@{#186}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
@rakuco rakuco force-pushed the master branch 2 times, most recently from 1072537 to 512d729 Compare January 21, 2016 15:50
@rakuco rakuco force-pushed the master branch 2 times, most recently from 0f31e18 to 3da217c Compare February 4, 2016 11:32
rakuco pushed a commit that referenced this pull request Mar 3, 2016
Fix the dynamic browser action setIcon path to work with any size icon.
14b3317 
BUG=564926,575256
[email protected]

Review URL: https://codereview.chromium.org/1580983002

Cr-Commit-Position: refs/heads/master@{#371133}
(cherry picked from commit 1686943)

Review URL: https://codereview.chromium.org/1647903003 .

Cr-Commit-Position: refs/branch-heads/2623@{#186}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
@rdcronin
[Extensions] Harden against bindings interception
8a4fb2b 
There's more we can do but this is a start.

BUG=590275
BUG=590118

Review URL: https://codereview.chromium.org/1748943002

Cr-Commit-Position: refs/heads/master@{#378621}
(cherry picked from commit 75b803b)

Review URL: https://codereview.chromium.org/1787433002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#186}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
@clelland
Clean up V8 bindings template code
891d66a 
This patch makes some of the V8 bindings templates a bit cleaner. Specifically:
 - Uses custom filters for the attribute list to duplicating complicated logic
   between for loops in the template and extra booleans defined in python.
 - Adds a unique_by filter to simplify the uniqueness logic in the templates.
 - Makes consistent use of the 'runtime_enabled' filter.
 - Combines for/endfor and if/endif tags into single for-if/endfor tags.
 - Makes use of the jinja2 'groupby' filter to clarify the complex logic for
   collecting and grouping runtime features by name.

It has a couple of visible side effects; mostly removing some extra generated
blank lines, and removing an unneeded extra brace pair in v8_dictionary.cpp (and
adjusting indentation appropriately). The text expectations have been updated to
match.

[email protected]

Review-Url: https://codereview.chromium.org/2000483002
Cr-Commit-Position: refs/heads/master@{#395067}
(cherry picked from commit b961967)

BUG=584367

Review URL: https://codereview.chromium.org/2029423002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#186}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
[CrOS Tether] Invoke any pending connection callbacks on shutdown.
7103446 
This ensures that there is no possibility for pending network connection
or disconnection requests when shutdown occurs. Leaving these pending
could leave the network stack in a bad state.

The original CL landed as [1] and was reverted as [2] due to an ASAN bot
failure. I've uploaded the original CL as patch 1 on this CL, and my fix
as patch 2.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/656570
[2] https://chromium-review.googlesource.com/c/chromium/src/+/659377

[email protected]

(cherry picked from commit 7dd2ddd)

Bug: 761541, 672263
Change-Id: I3e9beb0ad62fb92ca202f391229dbc46c9110b18
Reviewed-on: https://chromium-review.googlesource.com/663673
Reviewed-by: Ryan Hansberry <[email protected]>
Commit-Queue: Ryan Hansberry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#501397}
Reviewed-on: https://chromium-review.googlesource.com/663856
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#186}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.