Handle slot default content preview mode #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renan628
added
enhancement
renan628
requested review from
Fryuni,
bergaminifrg and
denis-rossati
and removed request for
bergaminifrg and
denis-rossati
denis-rossati
previously approved these changes
Nov 29, 2023
bergaminifrg
previously approved these changes
Nov 29, 2023
Fryuni
previously approved these changes
Dec 1, 2023
georgekaran
previously approved these changes
Dec 4, 2023
marcospassos
requested changes
Dec 4, 2023
renan628
dismissed stale reviews from georgekaran, Fryuni, bergaminifrg, and denis-rossati
via
6ef1588
[skip ci]
[skip ci]
[skip ci]
marcospassos
requested changes
Dec 8, 2023
preview/test/widget.spec.ts-snapshots/widget-without-locale-chromium.png
Outdated
Show resolved
Hide resolved
[skip ci]
[skip ci]
[skip ci]
marcospassos
requested changes
Dec 12, 2023
preview/test/widget.spec.ts-snapshots/widget-without-locale-webkit.png
Outdated
Show resolved
Hide resolved
marcospassos
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adapts the preview widget to handle the slot default content preview mode. If the changes the preview mode and the locale are obtained from the URL parameters in the plugin, and forwarded to the widget. Additionally, the
index.htmlused to test the widget was updated to reflect the plugin's behavior, nearing the test from the real scenario.Related to:
Checklist