-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix nested CWL enum in array and single-value combined + CWL Workflow step output chaining with glob #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m CWL/WPS outputs
…orkflow step output glob chaining
github-actions
bot
added
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/CWL
Issue related to CWL support
feature/oas
Issues related to OpenAPI specifications.
feature/providers
Issue related to providers convertion to WPS-REST processes.
process/workflow
Related to a Workflow process.
process/wps1
Issue related to WPS 1.x processes support
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
labels
Sep 22, 2023
@perronld |
…/weaver into fix-cwl-enum-schema-name
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
==========================================
+ Coverage 84.47% 84.55% +0.07%
==========================================
Files 79 79
Lines 17732 17788 +56
Branches 2688 2708 +20
==========================================
+ Hits 14979 15040 +61
+ Misses 2024 2020 -4
+ Partials 729 728 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/doc
Issue related to documentation of the package
ci/operations
Related to CI operations (actions, execution, install, builds, etc.)
ci/tests
Tests of the package and features
feature/CWL
Issue related to CWL support
feature/oas
Issues related to OpenAPI specifications.
feature/providers
Issue related to providers convertion to WPS-REST processes.
process/workflow
Related to a Workflow process.
process/wps1
Issue related to WPS 1.x processes support
process/wps3
Issue related to WPS 3.x (REST-JSON) processes support
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WpsProcessInterface.stage_output_id_nested
and enforce the behavior of nesting output by IDunder corresponding directories for all remote
Process
execution when resolvingCWL
Workflow
steps. Thisensures a more consistent file and directory resolution between steps of different nature (
CWL
,WPS
,OGC
based)using multiple combinations of
glob
patterns and expected media-types.Fixes
CWL
definitions combining nestedenum
types as["null", <enum>, {type: array, items: <enum>]
without anexplicit
name
orSchemaDefRequirement
causing failingschema_salad
resolution undercwltool
. A patchis applied for the moment to inject a temporary
name
to let theCWL
engine succeed schema validation (relatesto Schema salad error validating CWL enum definitions common-workflow-language/cwltool#1908.
References
AllowedValues
entries inensemble_grid_point_wetdays
process bird-house/finch#301