-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle multiple task outputs correctly in conditional tasks #1937
Open
devin-ai-integration
wants to merge
7
commits into
main
Choose a base branch
from
devin/1737479945-fix-conditional-index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+253
−8
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0082caf
fix: handle multiple task outputs correctly in conditional tasks
devin-ai-integration[bot] 4b767b2
feat: validate at least one non-conditional task and refine task outputs
devin-ai-integration[bot] 200ecff
Revert to single output in _create_crew_output; remove redundant empt…
devin-ai-integration[bot] 83ceacb
Merge branch 'main' into devin/1737479945-fix-conditional-index
bhancockio 9148e99
Address PR feedback: use last output in conditional tasks, add valida…
devin-ai-integration[bot] f641668
Merge branch 'devin/1737479945-fix-conditional-index' of https://gith…
devin-ai-integration[bot] b21e492
Address PR feedback: updated conditional tasks tests and indexing
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is basically the exact same as the one above it so we don't really need it.
Instead, let's change this test to verify that the result we get from crew.kickoff() properly contains all the task outputs. For example, if we have 3 tasks where 1 is normal and 2 are conditional tasks and 1 of those conditioanl tasks is never triggered, the task_outputs from crew.kickoff should only have 2 task outputs.