Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix breakage when cloning agent/crew using knowledge_sources and enable custom knowledge_storage #1927
fix breakage when cloning agent/crew using knowledge_sources and enable custom knowledge_storage #1927
Changes from 2 commits
f3004ff
dc9d1d6
c67f75d
591c4a5
71246e9
f34f53f
e3e62c1
65d3837
79aaab9
ab8d56d
849908c
c6d8c75
b87c908
27e4930
e4b97e3
24dbdd5
4008ba7
65b6ff1
079692d
4ff9d49
d438f5a
0675a2f
6fb654c
319128c
d506bdb
cb3865a
adec089
1cc9c98
f4b7cff
1de204e
9b88bcd
ac28f7f
42769e8
b92253b
8570461
b183aaf
fd89c3b
6617db7
c4da244
2816e97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
knowledge_sources=getattr(self, "knowledge_sources", None)
This is a little cleaner ^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test showing that we can successfully clone a crew with knowledge sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
knowledge_sources=getattr(self, "knowledge_sources", None)
Same here please.