Closure Specification Inference #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xldenis
force-pushed
the
closure-infer-new-new
branch
6 times, most recently
from
6529ab7
to
8e1863e
Compare
xldenis
force-pushed
the
closure-infer-new-new
branch
from
8e1863e
to
2207818
Compare
|
I see you updated some tests to use this, it looks good! Do you think |
arnaudgolfouse
force-pushed
the
closure-infer-new-new
branch
from
2207818
to
333d53f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the reason we adopted Coma in the first place, it allows us to infer the specifications of closures!
The implementation has one weakness:
postcondition_mutexpects a&mut Fwhich means we need to be able to create a borrow in Pearlite. For this reason I addedTermKind::Borrow, which is not super desirable. A motivated soul would refactorclosure_capture_substso that we can change the signature ofpostcondition_mutbut I unfortunately don't currently have enough time to tackle this.I think that this is still a worthwhile addition in the meantime which makes closures actually usable.