refactor: decline endorsement transaction API response

Signed-off-by: sanjay-k1910 <[email protected]>
credebl · Sep 11, 2024 · 7820746 · 7820746
1 parent 074b026
commit 7820746
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/apps/api-gateway/src/ecosystem/ecosystem.controller.ts b/apps/api-gateway/src/ecosystem/ecosystem.controller.ts
@@ -528,12 +528,13 @@ export class EcosystemController {
     @Param('orgId') orgId: string,
     @Res() res: Response
   ): Promise<object> {
-    await this.ecosystemService.declineEndorsementRequestByLead(ecosystemId, endorsementId, orgId);
+    const response = await this.ecosystemService.declineEndorsementRequestByLead(ecosystemId, endorsementId, orgId);
     const finalResponse: IResponse = {
-      statusCode: 200,
-      message: ResponseMessages.ecosystem.success.DeclineEndorsementTransaction
+      statusCode: HttpStatus.OK,
+      message: ResponseMessages.ecosystem.success.DeclineEndorsementTransaction,
+      data: response
     };
-    return res.status(200).json(finalResponse);
+    return res.status(HttpStatus.OK).json(finalResponse);
   }
 
 

diff --git a/apps/api-gateway/src/ecosystem/ecosystem.service.ts b/apps/api-gateway/src/ecosystem/ecosystem.service.ts
@@ -190,6 +190,6 @@ export class EcosystemService extends BaseService {
     orgId: string
   ): Promise<{ response: object }> {
     const payload = { ecosystemId, endorsementId, orgId };
-    return this.sendNats(this.serviceProxy, 'decline-endorsement-transaction', payload);
+    return this.sendNatsMessage(this.serviceProxy, 'decline-endorsement-transaction', payload);
   }
 }
diff --git a/apps/ecosystem/src/ecosystem.repository.ts b/apps/ecosystem/src/ecosystem.repository.ts
@@ -1071,7 +1071,8 @@ async findEcosystemMembers(
     }
   }
 
-  async updateEndorsementRequestStatus(ecosystemId: string, endorsementId: string): Promise<object> {
+  // eslint-disable-next-line camelcase
+  async updateEndorsementRequestStatus(ecosystemId: string, endorsementId: string): Promise<endorsement_transaction> {
     try {
 
       const endorsementTransaction = await this.prisma.endorsement_transaction.findUnique({

diff --git a/apps/ecosystem/src/ecosystem.service.ts b/apps/ecosystem/src/ecosystem.service.ts
@@ -1465,7 +1465,12 @@ export class EcosystemService {
 
   async declineEndorsementRequestByLead(ecosystemId: string, endorsementId: string): Promise<object> {
     try {
-      return await this.ecosystemRepository.updateEndorsementRequestStatus(ecosystemId, endorsementId);
+      const declineResponse = await this.ecosystemRepository.updateEndorsementRequestStatus(ecosystemId, endorsementId);
+
+      // To return selective response
+      this.removeEndorsementTransactionFields(declineResponse);
+
+      return declineResponse;
     } catch (error) {
       this.logger.error(`error in decline endorsement request: ${error}`);
       throw new RpcException(error.response ? error.response : error);