Add null alt element to icon img in HTML output

To improve accessibility
creativecommons · Apr 5, 2024 · c3d78b9 · c3d78b9
1 parent 5fdc53f
commit c3d78b9
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 70 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/utils/license-utilities.js b/src/utils/license-utilities.js
@@ -262,7 +262,7 @@ function generateLicenseLink(licenseIcons, licenseUrl, licenseName) {
   const iconSrc = attr =>
     `${ICON_BASE_URL}/${attr.toLowerCase()}.svg${assetPathRef}`;
   const icons = licenseIcons
-    .map(attr => `<img ${iconStyle} src="${iconSrc(attr)}">`)
+    .map(attr => `<img ${iconStyle} src="${iconSrc(attr)}" alt="">`)
     .join('');
 
   const linkHref = `href="${licenseUrl}${assetPathRef}"`;

diff --git a/tests/unit/specs/components/LicenseHTML.spec.js b/tests/unit/specs/components/LicenseHTML.spec.js
@@ -55,6 +55,11 @@ describe('LicenseHTML.vue', () => {
 
     const licenseIcons = wrapper.findAll('img');
     expect(licenseIcons.length).toBe(2);
+    // Icon img elements should have the following attributes: source, style and alt
+    const licenseIconsArray = licenseIcons.wrappers;
+    licenseIconsArray.forEach((img) => {
+      expect(Object.keys(img.attributes()).length).toBe(3);
+    });
   });
 
   it('has correct information when all attribution data is provided', async () => {
@@ -96,5 +101,10 @@ describe('LicenseHTML.vue', () => {
 
     const licenseIcons = wrapper.findAll('img');
     expect(licenseIcons.length).toBe(2);
+    // Icon img elements should have the following attributes: source, style and alt
+    const licenseIconsArray = licenseIcons.wrappers;
+    licenseIconsArray.forEach((img) => {
+      expect(Object.keys(img.attributes()).length).toBe(3);
+    });
   });
 });