add z/OS support #201
Merged
add z/OS support #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to follow the pattern used in pty_darwin.go, pty_freebsd.go & co, i.e. implement ptsname, unlockpt, etc instead of adding the sys/unix dependency? |
Done - note that it does depend on some runtime functions that are only present in the IBM maintained z/OS port of the Go compiler/library (just in case you were wondering where those functions came from) |
|
thanks! looks good. Does the runtime thing mean we require cgo on zos? |
|
No, CGO won't be required! |
creack
approved these changes
Oct 31, 2024
|
tagged and released. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds z/OS target support