slice: deprecate Dedup, shim to the equivalent stdlib slices.Compact #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
reviewed
Jul 25, 2024
danderson
force-pushed
the
push-qrwwmlwnvlsz
branch
2 times, most recently
from
0e774cf to
9a22284
Compare
There is a slight semantic change: elements beyond the end of the compacted slice are zeroed in slices.Compact. While this is a semantic change, it should be a strict improvement since people don't generally intend to hide old values (and pin pointers, from the GC's POV) in the unused part of a backing array.
danderson
force-pushed
the
push-qrwwmlwnvlsz
branch
from
9a22284 to
5502bda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slight semantic change: elements beyond the end of the compacted slice are zeroed in slices.Compact. While this is a semantic change, it should be a strict improvement since people don't generally intend to hide old values (and pin pointers, from the GC's POV) in the unused part of a backing array.
Random proposal, while I was in the area. WDYT?