Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MicroShift iso using image mode and bootc image builder #999

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

praveenkumar
Copy link
Member

With 4.18 microshift removed the steps of creating the iso using image builder and there is no more build.sh script which is consumed by mircoshift.sh script to create it. This PR use the image mode and bootc image builder (BIB) to create the iso which is now microshift team also pushing forward.

Copy link

openshift-ci bot commented Jan 10, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from praveenkumar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@praveenkumar praveenkumar force-pushed the issue_998 branch 4 times, most recently from 6ab8c1e to c074a21 Compare January 13, 2025 05:40
@praveenkumar
Copy link
Member Author

/test all

@praveenkumar praveenkumar marked this pull request as ready for review January 13, 2025 05:41
@openshift-ci openshift-ci bot requested review from anjannath and gbraad January 13, 2025 05:41
@praveenkumar praveenkumar force-pushed the issue_998 branch 2 times, most recently from 125c5ac to 83bd510 Compare January 13, 2025 08:09
@praveenkumar
Copy link
Member Author

/test e2e-microshift

@praveenkumar praveenkumar force-pushed the issue_998 branch 2 times, most recently from 7f20011 to 18006c3 Compare January 13, 2025 10:51
@praveenkumar praveenkumar force-pushed the issue_998 branch 4 times, most recently from 3610d4d to fd6b49f Compare January 14, 2025 04:09
@praveenkumar
Copy link
Member Author

/test e2e-microshift

@praveenkumar praveenkumar changed the title [WIP] Create MicroShift iso using image mode and bootc image builder Create MicroShift iso using image mode and bootc image builder Jan 15, 2025
@praveenkumar
Copy link
Member Author

/cherry-pick release-4.18

@openshift-cherrypick-robot

@praveenkumar: once the present PR merges, I will cherry-pick it on top of release-4.18 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@praveenkumar
Copy link
Member Author

/hold

With 4.18 microshift removed the steps of creating the iso using
image builder and there is no more `build.sh` script which is consumed
by mircoshift.sh script to create it. This PR use the image mode
and bootc image builder (BIB) to create the iso which is now microshift
team also pushing forward.
Copy link

openshift-ci bot commented Jan 17, 2025

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-snc 2c867a0 link true /test e2e-snc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar
Copy link
Member Author

/unhold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants