-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MicroShift iso using image mode and bootc image builder #999
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6ab8c1e
to
c074a21
Compare
/test all |
125c5ac
to
83bd510
Compare
/test e2e-microshift |
7f20011
to
18006c3
Compare
As per doc https://github.com/openshift/microshift/blob/main/docs/user/howto_config.md#drop-in-configuration-directory it is better to use the drop in configuration directory then changing the default one.
3610d4d
to
fd6b49f
Compare
/test e2e-microshift |
/cherry-pick release-4.18 |
@praveenkumar: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
fd6b49f
to
8e204a4
Compare
/hold |
With 4.18 microshift removed the steps of creating the iso using image builder and there is no more `build.sh` script which is consumed by mircoshift.sh script to create it. This PR use the image mode and bootc image builder (BIB) to create the iso which is now microshift team also pushing forward.
8e204a4
to
2c867a0
Compare
@praveenkumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/unhold |
With 4.18 microshift removed the steps of creating the iso using image builder and there is no more
build.sh
script which is consumed by mircoshift.sh script to create it. This PR use the image mode and bootc image builder (BIB) to create the iso which is now microshift team also pushing forward.