Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sql_exporter to 0.17.0 #704

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update sql_exporter to 0.17.0 #704

merged 1 commit into from
Jan 28, 2025

Conversation

goat-ssh
Copy link
Contributor

Also fix warning about metric being NULL:

level=WARN source=query.go:226 msg="Value column is NULL" logContext="collector=cratedb_cluster_last_user_activity_collector,query=cratedb_cluster_last_user_activity" column=cratedb_cluster_last_user_activity-collector

Summary of changes

Checklist

  • Link to issue this PR refers to: https://github.com/crate/cloud/issues/2402
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@goat-ssh
Update sql_exporter to 0.17.0
51a4597 
Also fix warning about metric being NULL:
```
level=WARN source=query.go:226 msg="Value column is NULL" logContext="collector=cratedb_cluster_last_user_activity_collector,query=cratedb_cluster_last_user_activity" column=cratedb_cluster_last_user_activity-collector
```
@goat-ssh goat-ssh requested review from tomach and plaharanne January 26, 2025 08:33
tomach
tomach approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@tomach tomach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goat-ssh goat-ssh merged commit ae141f2 into master Jan 28, 2025
5 checks passed
@goat-ssh goat-ssh deleted the s/sql_exporter-0.17.0 branch January 28, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomach tomach tomach approved these changes

@plaharanne plaharanne Awaiting requested review from plaharanne

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goat-ssh @tomach