Update -Cprocessors
on scale compute
#681
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Improve Resource Requests and Limits Handling for
start_cluster
function. And also change the jvm-CProcessor
setting which should reliably report the number of CPUs available in a docker environment.Updated
start_cluster
Function:resource_requests
andresource_limits
as separate parameters.Refactored
utils.py
:Enhanced Test Cases in
test_change_compute.py
:start_cluster
coroutine, as the test now needs to pull in the crate containercommands
from the Statefulset.-Cprocessors
are set correctly on scale compute.Thanks a lot to @Taliik for the help with the changes in the tests.
Checklist
CHANGES.rst