Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cors annotations in grand-central ingress #679

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

tomach
Copy link
Contributor

@tomach tomach commented Nov 21, 2024

Summary of changes

This change sets CORS annotations for ingress-nginx in the grand-central ingress to the same values we also use in the crate command in the StatefulSet. This is for

  • dev: https://console.cratedb-dev.cloud,http://localhost:8000
  • prod https://console.cratedb.cloud

Checklist

  • Link to issue this PR refers to:https://github.com/crate/cloud/issues/1932
  • Relevant changes are reflected in CHANGES.rst
  • Added or changed code is covered by tests
  • Documentation has been updated if necessary
  • Changed code does not contain any breaking changes (or this is a major version change)

@tomach tomach force-pushed the ta/grand-central-ingress branch 2 times, most recently from d6ff63d to 55ddfb1 Compare November 21, 2024 14:06
@tomach tomach force-pushed the ta/grand-central-ingress branch from 55ddfb1 to 9295eb7 Compare November 21, 2024 14:08
@tomach tomach changed the title Update cors headers in grand-central ingress Update cors annotations in grand-central ingress Nov 21, 2024
@tomach tomach marked this pull request as ready for review November 21, 2024 14:20
@tomach tomach merged commit 6da16cf into master Nov 22, 2024
5 checks passed
@tomach tomach deleted the ta/grand-central-ingress branch November 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants