Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore variants when product is restored #3880

Conversation

lukeholder
Copy link
Member

Description

Fixes the restore of variants when their product is restored.

The old deletedWithProduct never worked. The column in the variants table never was populated. deletedWithOwner is the correct property.

I have deprecated the property and marked it to be removed in next break-point.

Related issues

#3815

@lukeholder lukeholder requested a review from a team as a code owner February 4, 2025 05:40
Copy link

linear bot commented Feb 4, 2025

Copy link
Contributor

@nfourtythree nfourtythree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lukeholder lukeholder merged commit 28940a3 into 5.x Feb 4, 2025
11 checks passed
@lukeholder lukeholder deleted the feature/pt-2348-5x-restoring-a-soft-deleted-product-does-not-restore-its branch February 4, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants