Merge pull request #3878 from craftcms/bugfix/3873

Move recalculation inside of cart controller
craftcms · Feb 5, 2025 · 2088456 · 2088456
2 parents fee301f + f568ee5
commit 2088456
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Fixed a bug where the `commerce/cart/update-cart` action could return unnecessary validation errors. ([3873](https://github.com/craftcms/commerce/issues/3873))
 - Improved logging when a user deletion is prevented due to the user having Commerce orders. ([#3686](https://github.com/craftcms/commerce/issues/3686))
 
 ## 4.8.0.1 - 2025-02-03

diff --git a/src/controllers/CartController.php b/src/controllers/CartController.php
@@ -526,6 +526,9 @@ private function _returnCart(): ?Response
 
         $updateCartSearchIndexes = Plugin::getInstance()->getSettings()->updateCartSearchIndexes;
 
+        $this->_cart->recalculate();
+        $this->_cart->recalculationMode = Order::RECALCULATION_MODE_NONE;
+
         // Do not clear errors, as errors could be added to the cart before _returnCart is called.
         if (!$this->_cart->validate($attributes, false) || !Craft::$app->getElements()->saveElement($this->_cart, false, false, $updateCartSearchIndexes)) {
             $error = Craft::t('commerce', 'Unable to update cart.');
@@ -559,6 +562,8 @@ private function _returnCart(): ?Response
             $this->_mutex->release($this->_mutexLockName);
         }
 
+        $this->_cart->recalculationMode = Order::RECALCULATION_MODE_ALL;
+
         return $this->asModelSuccess(
             $this->_cart,
             $message,