Operation overhaul with RefreshIG/ExtractMatBundle multithreaded enhancements #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…now includes fhir server entry in arguments.
…ientUtils to collect POST calls and execute them at the end.
…ses for thread safety. Declaring certain variables outside of loops for stability.
…into refresh-ig-caching
…ty reasons (ddos false flag)
…needed due to the nature of modifications of each by the process.
…etter performance.
…usted IOUtils.copyFile to return false if the file wasn't copied, true if it was, to accurately track how many files get copied during TestCaseProcessor.bundleTestCaseFiles
…actMatBundleOperation with multithreading, updated matching test accordingly
* Moved the processing of a file to its own method, incorporated a for loop into the execute method should -dir be passed in. * Finished with directory processing, adding test. * Fixed issue with test, now verify Bundle using instanceof * Removed member variable references for readability. * Validating input earlier, adjusted BundlUtils to handle logic about versioning the method call. * 80% code coverage on ExtractMatBundleOperation class * Added more robust tests for the supplied output directory by the user * Removed unused test * Added transactional bundle files for tests to POST * Added commented out line for localhost POST testing. * Updated ExtractMatBundle tests to cover wider range of file types and content. * Eliminating unused resource * Added resource ID verification so resources aren't processed repeatedly. Once extracted from a transaction bundle, the resource ID is logged, and if found in another bundle, removed from that bundle prior to processing it. * Fixed failing tests elsewhere in the app on null outputpath * Removing RefreshIG work accidentally included in this branch * Restoring Main documentation for -dir * Correcting failing test --------- Co-authored-by: Evan Chicoine <[email protected]>
… file count due to old approach to eliminating duplicate resource processing
…y issues in tests. IGBundleProcessor checking fhirUri for null before reference. RefreshIGOperationTest using wiremock to monitor post calls to mock fhir server. pom.xml updated for wiremock. Will possibly try different libraries for similar approach.
added 25 commits
October 25, 2023 13:04
…lasses should be reset after the process. cleanUp() added to various classes and called from IGBundleProcessor at the end of the process so subsequent tests start fresh like the app restarted. TODO: Move away from static!
…c/test/java/org/opencds/cqf/tooling/operation/StripGeneratedContentOperationTest.java as it is failing in Windows but not linux.
…ssor as it's too unstable at the server during ci checks, and added conditional path processing to tooling/src/test/java/org/opencds/cqf/tooling/operation/StripGeneratedContentOperationTest.java
…LibraryDependenciesTasks. Adjusted error handling for clear information in console when shouldPersist finds an error.
…evious approach to IOUtils.getFilePaths (caching retained) because readability exceeds any performance benefit from Files.walk
… to reduce duplication of code
…on-overhaul-multithreaded # Conflicts: # tooling/src/main/java/org/opencds/cqf/tooling/library/LibraryProcessor.java # tooling/src/main/java/org/opencds/cqf/tooling/measure/MeasureProcessor.java # tooling/src/main/java/org/opencds/cqf/tooling/processor/PlanDefinitionProcessor.java # tooling/src/main/java/org/opencds/cqf/tooling/processor/TestCaseProcessor.java # tooling/src/main/java/org/opencds/cqf/tooling/questionnaire/QuestionnaireProcessor.java # tooling/src/main/java/org/opencds/cqf/tooling/utilities/BundleUtils.java # tooling/src/main/java/org/opencds/cqf/tooling/utilities/HttpClientUtils.java # tooling/src/main/java/org/opencds/cqf/tooling/utilities/IOUtils.java # tooling/src/main/java/org/opencds/cqf/tooling/utilities/LogUtils.java # tooling/src/main/java/org/opencds/cqf/tooling/utilities/ResourceUtils.java # tooling/src/test/java/org/opencds/cqf/tooling/operation/RefreshIGOperationTest.java # tooling/src/test/java/org/opencds/cqf/tooling/processor/IGProcessorTest.java
…atorException giving us the ability to pass back the list of errors as as a Set (to easily avoid duplicate warnings.)
…to avoid warning (and failure in tests.) Fixed typo in moveAndRename
|
Hi, why wasn't this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By creating this PR you acknowledge that your contribution will be licensed under Apache 2.0